Skip to content

Commit 8d266b1

Browse files
committed
Merge pull request #190 from arschles/helm-chart-steps
doc(releasing.md): merge helm documentation update step into the helm chart update step
2 parents 67f8c25 + 8d67bc2 commit 8d266b1

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

src/contributing/releasing.md

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,11 @@ to reference the official images. To do so, simply modify all `dockerTag` entrie
111111
`generate_params.toml` files in the `workflow-$DEIS_RELEASE_SHORT` and
112112
`workflow-$DEIS_RELEASE_SHORT-e2e` to be `$DEIS_RELEASE` (instead of the ones based on git tags).
113113

114-
When you're done, commit and push your changes. You should get your pull request reviewed and
115-
merged before continuing.
114+
Also, ensure that the `README.md` and `Chart.yaml` files in the new helm chart have updated references to the chart. For example, references to `helm install workflow-betaX` should become `helm install workflow-$DEIS_RELEASE_SHORT`
115+
116+
If you find any references that should be bumped, open a pull-request against the documentation.
117+
118+
When you're done, commit and push your changes. You should get your pull request reviewed and merged before continuing.
116119

117120
# Step 6: Update Changelogs
118121

@@ -163,14 +166,7 @@ GitHub project. To do so, simply run the below command in the `deis-workflow-gro
163166
TAG=$DEIS_RELEASE TAG_MESSAGE="releasing workflow $DEIS_RELEASE" make git-tag git-tag-push
164167
```
165168

166-
# Step 8: Check documentation
167-
168-
Now that the chart has been merged, artifacts pushed, and changelogs prepared.
169-
Check the documentation for any out of date references, e.g. `helm install workflow-betaX`.
170-
171-
If you find any references that should be bumped, open a pull-request against the documentation.
172-
173-
# Step 9: Let everyone know
169+
# Step 8: Let everyone know
174170

175171
Jump in #company on slack and let folks know that the release has been cut! This will let
176172
folks in supporting functions know that they should start the release support process including

0 commit comments

Comments
 (0)