Skip to content

Commit 8d67bc2

Browse files
author
Aaron Schlesinger
committed
doc(releasing.md): merge helm documentation update step into the helm chart update step
1 parent 6c65793 commit 8d67bc2

1 file changed

Lines changed: 6 additions & 10 deletions

File tree

src/contributing/releasing.md

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,11 @@ to reference the official images. To do so, simply modify all `dockerTag` entrie
106106
`generate_params.toml` files in the `workflow-$DEIS_RELEASE_SHORT` and
107107
`workflow-$DEIS_RELEASE_SHORT-e2e` to be `$DEIS_RELEASE` (instead of the ones based on git tags).
108108

109-
When you're done, commit and push your changes. You should get your pull request reviewed and
110-
merged before continuing.
109+
Also, ensure that the `README.md` and `Chart.yaml` files in the new helm chart have updated references to the chart. For example, references to `helm install workflow-betaX` should become `helm install workflow-$DEIS_RELEASE_SHORT`
110+
111+
If you find any references that should be bumped, open a pull-request against the documentation.
112+
113+
When you're done, commit and push your changes. You should get your pull request reviewed and merged before continuing.
111114

112115
# Step 6: Update Changelogs
113116

@@ -159,14 +162,7 @@ TAG=$DEIS_RELEASE TAG_MESSAGE="releasing workflow $DEIS_RELEASE" make git-tag
159162
make git-tag-push
160163
```
161164

162-
# Step 8: Check documentation
163-
164-
Now that the chart has been merged, artifacts pushed, and changelogs prepared.
165-
Check the documentation for any out of date references, e.g. `helm install workflow-betaX`.
166-
167-
If you find any references that should be bumped, open a pull-request against the documentation.
168-
169-
# Step 9: Let everyone know
165+
# Step 8: Let everyone know
170166

171167
Jump in #company on slack and let folks know that the release has been cut! This will let
172168
folks in supporting functions know that they should start the release support process including

0 commit comments

Comments
 (0)