Skip to content

Commit 75602df

Browse files
author
Vaughn Dice
committed
feat(Makefile): move prep-bintray-json and _scripts/ci into client directory
We want client's VERSION to be used by the prep-bintray-json (previously workflow's VERSION was being used). As client is the only current consumer of this make task, we've moved it into client along with supporting scripts.
1 parent 41d3236 commit 75602df

5 files changed

Lines changed: 12 additions & 14 deletions

File tree

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ venv/
4444
vendor/
4545

4646
# generated bintray scripts during ci
47-
_scripts/ci/bintray-ci.json
47+
client/_scripts/ci/bintray-ci.json

.travis.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,10 @@ install:
3232
- pip install -r rootfs/dev_requirements.txt
3333
- make -C docs/ deps
3434
- GLIDE_HOME=/home/travis/.glide make -C client bootstrap
35-
- make prep-bintray-json
3635
script:
3736
- make test
38-
- make -C client/ bootstrap build test dist
37+
- make -C client/ bootstrap build test dist prep-bintray-json
3938
- make -C docs/ build test
40-
- make prep-bintray-json
4139
deploy:
4240
- provider: script
4341
# ensure client/doc builds aren't removed

Makefile

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,6 @@ check-docker:
1717
exit 2; \
1818
fi
1919

20-
prep-bintray-json:
21-
# TRAVIS_TAG is set to the tag name if the build is a tag
22-
ifdef TRAVIS_TAG
23-
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json | \
24-
jq '.package.repo |= "deis"' > _scripts/ci/bintray-ci.json
25-
else
26-
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json \
27-
> _scripts/ci/bintray-ci.json
28-
endif
29-
3020
build: docker-build
3121

3222
docker-build: check-docker

client/Makefile

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,16 @@ define check-static-binary
2626
fi
2727
endef
2828

29+
prep-bintray-json:
30+
# TRAVIS_TAG is set to the tag name if the build is a tag
31+
ifdef TRAVIS_TAG
32+
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json | \
33+
jq '.package.repo |= "deis"' > _scripts/ci/bintray-ci.json
34+
else
35+
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json \
36+
> _scripts/ci/bintray-ci.json
37+
endif
38+
2939
bootstrap:
3040
${DEV_ENV_CMD} glide install
3141

0 commit comments

Comments
 (0)