Merge pull request #379 from smothiki/health

feat(healthcheck): remove default healthcheck for apps

Author: Sivaram Mothiki

rootfs/api/models/config.py

@@ -28,9 +28,11 @@ def __str__(self):
 
     def healthcheck(self):
         # Update healthcheck - Scheduler determines the app type
+        if 'HEALTHCHECK_URL' not in self.values.keys():
+            return {}
         path = self.values.get('HEALTHCHECK_URL', '/')
-        timeout = int(self.values.get('HEALTHCHECK_TIMEOUT', 1))
-        delay = int(self.values.get('HEALTHCHECK_INITIAL_DELAY', 10))
+        timeout = int(self.values.get('HEALTHCHECK_TIMEOUT', 50))
+        delay = int(self.values.get('HEALTHCHECK_INITIAL_DELAY', 50))
         port = int(self.values.get('HEALTHCHECK_PORT', 8080))
 
         return {'path': path, 'timeout': timeout, 'delay': delay, 'port': port}

rootfs/scheduler/__init__.py

@@ -652,7 +652,8 @@ def _create_rc(self, name, image, command, **kwargs):  # noqa
             containers[0]["resources"]["limits"]["cpu"] = cpu
 
         # add in healtchecks
-        js_template = self._healthcheck(js_template, **kwargs['healthcheck'])
+        if kwargs.get('healthcheck'):
+            js_template = self._healthcheck(js_template, **kwargs['healthcheck'])
 
         url = self._api("/namespaces/{}/replicationcontrollers", app_name)
         resp = self.session.post(url, json=js_template)