fix(controller): remove username length validation

This fix that was implemented in #631 was a bit hackish, and was
only used because we stored the images as username/appname in the
registry. The registry has a restriction where the username has
to be greater than or equal to 4 in length. Now that we are not
storing the images with the associated owner's username, we no
longer need this restriction.

reverts #631

Author: Matthew Fisher

controller/api/exceptions.py

@@ -5,7 +5,6 @@
 from __future__ import unicode_literals
 
 from rest_framework.exceptions import APIException
-from rest_framework import status
 
 
 class AbstractDeisException(APIException):
@@ -22,10 +21,3 @@ def __init__(self, detail=None):
 
     class Meta:
         abstract = True
-
-
-class UserRegistrationException(AbstractDeisException):
-    """
-    Indicates that there was a problem registering the user.
-    """
-    status_code = status.HTTP_400_BAD_REQUEST

controller/api/tests/test_auth.py

@@ -56,10 +56,6 @@ def test_auth(self):
         self.assertFalse(response.data['is_staff'])
         self.assertTrue(
             self.client.login(username=username, password=password))
-        # test with len(username) < 4
-        submit['username'] = 'new'
-        response = self.client.post(url, json.dumps(submit), content_type='application/json')
-        self.assertEqual(response.status_code, 400)
         # test logout and login
         url = '/api/auth/logout/'
         response = self.client.post(url, content_type='application/json')

controller/api/views.py

@@ -22,7 +22,6 @@
 from rest_framework.response import Response
 
 from api import models, serializers
-from .exceptions import UserRegistrationException
 
 from django.conf import settings
 
@@ -147,9 +146,6 @@ def pre_save(self, obj):
         obj.is_active = True
         obj.email = User.objects.normalize_email(obj.email)
         obj.set_password(obj.password)
-        # FIXME: move this business logic to the model
-        if len(obj.username) < 4:
-            raise UserRegistrationException('username must be >= 4 characters in length')
         # Make this first signup an admin / superuser
         if not User.objects.filter(is_superuser=True).exists():
             obj.is_superuser = obj.is_staff = True