fix(registry): store apps as appname

Storing the image in the registry as user/appname introduces a couple
of confusing ideas:

- images are implied to be unique across accounts
- images are owned by one user and one only

Point 1 is incorrect. App names are completely unique across the
entire cluster[1]. Point 2 is incorrect as well because apps can
be shared with the `deis perms` command. Changing the name of the
image in the registry from `user/appname` to `appname` makes the
image names unique across the entire cluster as well as making the
images more easily sharable between users.

fixes #729

[1]: https://github.com/deis/deis/blob/d1e14a6f76789a86f1959ba7bf6057b3abe3b960/controller/api/models.py#L109

BREAKING CHANGES: because this changes the way that applications
are stored in the registry, this is a backwards-incompatible change
with applications prior to this commit. To migrate over to this change,
you'll have to destroy and re-create your apps with the same name
as it was before. The docker layers from previous builds will still
exist in the registry, but the repository names will be changed
to reflect this change.

Author: Matthew Fisher

builder/templates/builder

@@ -36,8 +36,8 @@ if __name__ == '__main__':
     user, repo, app = parse_args()
     # define image names
     _id = uuid.uuid4().hex[:8]
-    tmp_image = "{user}/{app}:temp_{_id}".format(**locals())
-    target_image = "{{ .deis_registry_host }}:{{ .deis_registry_port }}/{user}/{app}".format(**locals())
+    tmp_image = "{app}:temp_{_id}".format(**locals())
+    target_image = "{{ .deis_registry_host }}:{{ .deis_registry_port }}/{app}".format(**locals())
     # create required directories
     repo_dir = os.path.join(os.getcwd(), repo)
     build_dir = os.path.join(repo_dir, 'build')

controller/api/models.py

@@ -428,7 +428,7 @@ def new(self, user, config=None, build=None, summary=None):
             owner=user, app=self.app, config=config,
             build=build, version=new_version, image=image, summary=summary)
         # publish release to registry as new docker image
-        repository_path = "{}/{}".format(user.username, self.app.id)
+        repository_path = self.app.id
         publish_release(repository_path, config.values, tag)
         return release
 

controller/api/tests/test_hooks.py

@@ -106,7 +106,7 @@ def test_build_hook(self):
         url = '/api/hooks/builds'.format(**locals())
         body = {'receive_user': 'autotest',
                 'receive_repo': app_id,
-                'image': 'registry.local:5000/autotest/{app_id}:v2'.format(**locals())}
+                'image': 'registry.local:5000/{app_id}:v2'.format(**locals())}
         # post the build without a session
         self.assertIsNone(self.client.logout())
         response = self.client.post(url, json.dumps(body), content_type='application/json')