Skip to content

Commit 10ba262

Browse files
committed
chore(ingress): renmae use_native_ingress to use_ingress
1 parent 6914ea9 commit 10ba262

6 files changed

Lines changed: 10 additions & 10 deletions

File tree

charts/controller/templates/controller-clusterrole.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ rules:
5050
- apiGroups: ["extensions", "autoscaling"]
5151
resources: ["horizontalpodautoscalers"]
5252
verbs: ["get", "list", "create", "update", "delete"]
53-
{{ if .Values.global.use_native_ingress }}
53+
{{ if .Values.global.use_ingress }}
5454
- apiGroups: ["extensions"]
5555
resources: ["ingresses"]
5656
verbs: ["get", "list", "watch", "create", "update", "delete"]

charts/controller/templates/controller-deployment.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,13 @@ spec:
6060
value: "127.0.0.1"
6161
# Environmental variable value for $USE_NATIVE_INGRESS
6262
- name: "USE_NATIVE_INGRESS"
63-
value: "{{ .Values.global.use_native_ingress }}"
64-
- name: "USE_NATIVE_INGRESS_HOSTNAME"
63+
value: "{{ .Values.global.use_ingress }}"
64+
- name: "INGRESS_HOSTNAME"
6565
value: "{{ .Values.platform_domain }}"
6666
- name: "K8S_API_VERIFY_TLS"
6767
value: "{{ .Values.k8s_api_verify_tls }}"
6868
- name: "DRYCC_REGISTRY_SERVICE_PORT"
69-
value: "{{ .Values.global.host_port }}"
69+
value: "{{ .Values.global.registry_service_port }}"
7070
- name: "APP_STORAGE"
7171
value: "{{ .Values.global.storage}}"
7272
- name: "DRYCC_REGISTRY_LOCATION"

charts/controller/templates/controller-ingress-rule-http-80.yaml renamed to charts/controller/templates/controller-ingress.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
{{ if .Values.global.use_native_ingress }}
1+
{{ if .Values.global.use_ingress }}
22
apiVersion: extensions/v1beta1
33
kind: Ingress
44
metadata:
55
namespace: "{{ .Release.Namespace }}"
6-
name: "controller-api-server-ingress-http"
6+
name: "controller-api-server-ingress"
77
labels:
88
app: "controller"
99
chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"

charts/controller/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ global:
4747
# - gcr: Use Google's GCR
4848
registry_location: "on-cluster"
4949
# The host port to which registry proxy binds to
50-
host_port: 5555
50+
registry_service_port: 5555
5151
# Prefix for the imagepull secret created when using private registry
5252
secret_prefix: "private-registry"
5353
# Experimental feature to toggle using kubernetes ingress instead of the Drycc router.
5454
#
5555
# Valid values are:
5656
# - true: The drycc controller will now create Kubernetes ingress rules for each app, and ingress rules will automatically be created for the controller itself.
5757
# - false: The default mode, and the default behavior of Drycc workflow.
58-
use_native_ingress: false
58+
use_ingress: false
5959
# Role-Based Access Control for Kubernetes >= 1.5
6060
use_rbac: false

rootfs/api/models/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ def create(self, *args, **kwargs): # noqa
239239
self.log("creating Ingress {}".format(namespace), level=logging.INFO)
240240
self._scheduler.ingress.create(ingress,
241241
namespace,
242-
settings.USE_NATIVE_INGRESS_HOSTNAME)
242+
settings.INGRESS_HOSTNAME)
243243
except KubeException as e:
244244
raise ServiceUnavailable('Could not create Ingress in Kubernetes') from e
245245
try:

rootfs/api/settings/production.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@
263263
# experimental native ingress
264264
USE_NATIVE_INGRESS = bool(strtobool(
265265
os.environ.get('USE_NATIVE_INGRESS', 'false')))
266-
USE_NATIVE_INGRESS_HOSTNAME = os.environ.get('USE_NATIVE_INGRESS_HOSTNAME', '')
266+
INGRESS_HOSTNAME = os.environ.get('INGRESS_HOSTNAME', '')
267267

268268
# k8s image policies
269269
SLUGRUNNER_IMAGE = os.environ.get('SLUGRUNNER_IMAGE_NAME', 'quay.io/drycc/slugrunner:canary') # noqa

0 commit comments

Comments
 (0)