Skip to content

Commit 6914ea9

Browse files
committed
chore(workflow): change experimental_native_ingress to use_native_ingress
1 parent 1a6a2bd commit 6914ea9

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

charts/controller/templates/controller-clusterrole.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ rules:
5050
- apiGroups: ["extensions", "autoscaling"]
5151
resources: ["horizontalpodautoscalers"]
5252
verbs: ["get", "list", "create", "update", "delete"]
53-
{{ if .Values.global.experimental_native_ingress }}
53+
{{ if .Values.global.use_native_ingress }}
5454
- apiGroups: ["extensions"]
5555
resources: ["ingresses"]
5656
verbs: ["get", "list", "watch", "create", "update", "delete"]

charts/controller/templates/controller-deployment.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ spec:
5858
# NOTE(bacongobbler): use drycc/registry_proxy to work around Docker --insecure-registry requirements
5959
- name: "DRYCC_REGISTRY_SERVICE_HOST"
6060
value: "127.0.0.1"
61-
# Environmental variable value for $EXPERIMENTAL_NATIVE_INGRESS
62-
- name: "EXPERIMENTAL_NATIVE_INGRESS"
63-
value: "{{ .Values.global.experimental_native_ingress }}"
64-
- name: "EXPERIMENTAL_NATIVE_INGRESS_HOSTNAME"
61+
# Environmental variable value for $USE_NATIVE_INGRESS
62+
- name: "USE_NATIVE_INGRESS"
63+
value: "{{ .Values.global.use_native_ingress }}"
64+
- name: "USE_NATIVE_INGRESS_HOSTNAME"
6565
value: "{{ .Values.platform_domain }}"
6666
- name: "K8S_API_VERIFY_TLS"
6767
value: "{{ .Values.k8s_api_verify_tls }}"

charts/controller/templates/controller-ingress-rule-http-80.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{ if .Values.global.experimental_native_ingress }}
1+
{{ if .Values.global.use_native_ingress }}
22
apiVersion: extensions/v1beta1
33
kind: Ingress
44
metadata:

charts/controller/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ global:
5555
# Valid values are:
5656
# - true: The drycc controller will now create Kubernetes ingress rules for each app, and ingress rules will automatically be created for the controller itself.
5757
# - false: The default mode, and the default behavior of Drycc workflow.
58-
experimental_native_ingress: false
58+
use_native_ingress: false
5959
# Role-Based Access Control for Kubernetes >= 1.5
6060
use_rbac: false

rootfs/api/models/app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ def create(self, *args, **kwargs): # noqa
230230

231231
try:
232232
# In order to create an ingress, we must first have a namespace.
233-
if settings.EXPERIMENTAL_NATIVE_INGRESS:
233+
if settings.USE_NATIVE_INGRESS:
234234
if ingress == "":
235235
raise ServiceUnavailable('Empty hostname')
236236
try:
@@ -239,7 +239,7 @@ def create(self, *args, **kwargs): # noqa
239239
self.log("creating Ingress {}".format(namespace), level=logging.INFO)
240240
self._scheduler.ingress.create(ingress,
241241
namespace,
242-
settings.EXPERIMENTAL_NATIVE_INGRESS_HOSTNAME)
242+
settings.USE_NATIVE_INGRESS_HOSTNAME)
243243
except KubeException as e:
244244
raise ServiceUnavailable('Could not create Ingress in Kubernetes') from e
245245
try:

rootfs/api/settings/production.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,9 +261,9 @@
261261
BUILDER_KEY = os.environ.get('DRYCC_BUILDER_KEY', random_secret)
262262

263263
# experimental native ingress
264-
EXPERIMENTAL_NATIVE_INGRESS = bool(strtobool(
265-
os.environ.get('EXPERIMENTAL_NATIVE_INGRESS', 'false')))
266-
EXPERIMENTAL_NATIVE_INGRESS_HOSTNAME = os.environ.get('EXPERIMENTAL_NATIVE_INGRESS_HOSTNAME', '')
264+
USE_NATIVE_INGRESS = bool(strtobool(
265+
os.environ.get('USE_NATIVE_INGRESS', 'false')))
266+
USE_NATIVE_INGRESS_HOSTNAME = os.environ.get('USE_NATIVE_INGRESS_HOSTNAME', '')
267267

268268
# k8s image policies
269269
SLUGRUNNER_IMAGE = os.environ.get('SLUGRUNNER_IMAGE_NAME', 'quay.io/drycc/slugrunner:canary') # noqa

0 commit comments

Comments
 (0)