Skip to content

Commit 4f902e3

Browse files
committed
chore(ingress): use ingress_class
1 parent 23f5dff commit 4f902e3

2 files changed

Lines changed: 13 additions & 10 deletions

File tree

charts/builder/templates/builder-service.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,9 @@ spec:
99
- name: ssh
1010
port: 2222
1111
targetPort: 2223
12+
{{- if (and (eq .Values.service.type "NodePort") (not (empty .Values.service.nodePort))) }}
13+
nodePort: {{ .Values.service.nodePort }}
14+
{{- end }}
1215
selector:
1316
app: drycc-builder
14-
{{ if .Values.ingress.enabled }}
15-
type: "LoadBalancer"
16-
{{ end }}
17+
type: {{ .Values.service.type }}

charts/builder/values.yaml

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,20 @@ org: "drycc"
22
pull_policy: "Always"
33
docker_tag: "canary"
44
docker_registry: ""
5+
service:
6+
# Service type default to LoadBalancer
7+
type: ClusterIP
8+
# If service.type is not set to NodePort, the following statement will be ignored.
9+
nodePort: ""
510
# limits_cpu: "100m"
611
# limits_memory: "50Mi"
712
# builder_pod_node_selector: "disk:ssd"
813

914
global:
1015
# Role-Based Access Control for Kubernetes >= 1.5
1116
use_rbac: false
12-
13-
ingress:
1417
# Experimental feature to use Kubernetes ingress instead of Workflow's drycc-router.
15-
#
16-
# Valid values are:
17-
# - true: drycc-router will not be deployed. Workflow will not be usable until a Kubernetes ingress controller is installed.
18-
# - false: drycc-router will be deployed (default).
19-
enabled: false
18+
# If ingress_class is empty, use drycc-router
19+
# Otherwise, please check `kubernetes.io/ingress.class`
20+
# The cert-manager component must be installed
21+
ingress_class: ""

0 commit comments

Comments
 (0)