Skip to content

Commit 23f5dff

Browse files
committed
chore(ingress): change global.use_ingress to ingress.enabled
1 parent fc62fe0 commit 23f5dff

2 files changed

Lines changed: 9 additions & 7 deletions

File tree

charts/builder/templates/builder-service.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,6 @@ spec:
1111
targetPort: 2223
1212
selector:
1313
app: drycc-builder
14-
{{ if .Values.global.use_ingress }}
14+
{{ if .Values.ingress.enabled }}
1515
type: "LoadBalancer"
1616
{{ end }}

charts/builder/values.yaml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ docker_registry: ""
77
# builder_pod_node_selector: "disk:ssd"
88

99
global:
10-
# Experimental feature to toggle using kubernetes ingress instead of the Drycc router.
11-
#
12-
# Valid values are:
13-
# - true: The drycc controller will now create Kubernetes ingress rules for each app, and ingress rules will automatically be created for the controller itself.
14-
# - false: The default mode, and the default behavior of Drycc workflow.
15-
use_ingress: false
1610
# Role-Based Access Control for Kubernetes >= 1.5
1711
use_rbac: false
12+
13+
ingress:
14+
# Experimental feature to use Kubernetes ingress instead of Workflow's drycc-router.
15+
#
16+
# Valid values are:
17+
# - true: drycc-router will not be deployed. Workflow will not be usable until a Kubernetes ingress controller is installed.
18+
# - false: drycc-router will be deployed (default).
19+
enabled: false

0 commit comments

Comments
 (0)