Skip to content

Commit fe7d82e

Browse files
committed
chore(release): add a new removal step for release-checklist
1 parent 3d6a85c commit fe7d82e

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

src/roadmap/release-checklist.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,12 @@ version of our release for testing. The process is fairly simple:
6565
`dockerTag` values look like `git-$COMPONENT_SHA_SHORT`, where `$COMPONENT_SHA_SHORT` is the first
6666
7 characters of the applicable SHA that you got in the previous step.
6767
4. Ensure that all `DEBUG` variables in manifests are `false`.
68-
5. Commit your changes: `git commit -a -m "chore(workflow-$DEIS_RELEASE_SHORT): releasing workflow-$DEIS_RELEASE_SHORT"`
69-
6. Push your changes to your fork: `git push -u $YOUR_FORK_REMOTE release-$DEIS_RELEASE`. Note that
68+
5. Delete the `KUBERNETES_POD_TERMINATION_GRACE_PERIOD_SECONDS` env var from `tpl/deis-controller-rc.yaml`
69+
6. Commit your changes: `git commit -a -m "chore(workflow-$DEIS_RELEASE_SHORT): releasing workflow-$DEIS_RELEASE_SHORT"`
70+
7. Push your changes to your fork: `git push -u $YOUR_FORK_REMOTE release-$DEIS_RELEASE`. Note that
7071
`$YOUR_FORK_REMOTE` is the git URI to the remote of your `deis/charts` fork. Mine is `git@github.com:arschles/deis-charts.git`, for example.
71-
7. Do steps 2-5 with the `workflow-beta3-e2e` directory
72-
8. Open a pull request from your branch to merge into `master` on https://github.com/deis/charts
72+
8. Do steps 2-5 with the `workflow-beta3-e2e` directory
73+
9. Open a pull request from your branch to merge into `master` on https://github.com/deis/charts
7374

7475
# Step 3: Manual Testing
7576

0 commit comments

Comments
 (0)