Skip to content

Commit dad9598

Browse files
committed
docs(submitting-a-pr): add "hotfix revert" exception to LGTM rules
Much discussion around streamlining code review and approval led to consensus on this change.
1 parent 433ff23 commit dad9598

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/contributing/submitting-a-pull-request.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ No pull requests can be merged until at least one core maintainer signs off with
9191

9292
If the PR is from a Deis maintainer, then he or she should be the one to close it. This keeps the commit stream clean and gives the maintainer the benefit of revisiting the PR before deciding whether or not to merge the changes.
9393

94+
An exception to this is when an errant commit needs to be reverted urgently. If necessary, a PR that only reverts a previous commit can be merged without waiting for LGTM approval.
95+
9496
[go]: http://golang.org/
9597
[glide]: https://github.com/Masterminds/glide
9698
[flake8]: https://pypi.python.org/pypi/flake8/

0 commit comments

Comments
 (0)