Skip to content

Commit d64c6ea

Browse files
committed
chore(ingress): change global.use_ingress to ingress.enabled
1 parent 2085c65 commit d64c6ea

2 files changed

Lines changed: 13 additions & 8 deletions

File tree

charts/workflow/values.yaml

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,12 +52,6 @@ global:
5252
registry_service_port: 5555
5353
# Prefix for the imagepull secret created when using private registry
5454
secret_prefix: "private-registry"
55-
# Experimental feature to use Kubernetes ingress instead of Workflow's drycc-router.
56-
#
57-
# Valid values are:
58-
# - true: drycc-router will not be deployed. Workflow will not be usable until a Kubernetes ingress controller is installed.
59-
# - false: drycc-router will be deployed (default).
60-
use_ingress: false
6155
# If the Kubernetes cluster uses CNI
6256
# use_cni: true
6357
# Set the `listen` variable for registry-proxy's NGINX
@@ -239,6 +233,17 @@ router:
239233
https: ""
240234
healthz: ""
241235

236+
ingress:
237+
# Experimental feature to use Kubernetes ingress instead of Workflow's drycc-router.
238+
#
239+
# Valid values are:
240+
# - true: drycc-router will not be deployed. Workflow will not be usable until a Kubernetes ingress controller is installed.
241+
# - false: drycc-router will be deployed (default).
242+
enabled: false
243+
# annotations:
244+
# kubernetes.io/ingress.class: nginx
245+
# kubernetes.io/tls-acme: 'true'
246+
242247
workflow-manager:
243248
versions_api_url: https://versions.drycc.cc
244249
doctor_api_url: https://doctor.drycc.cc
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
Now that Helm is installed and the repository has been added, install Workflow with a native ingress by running:
66

77
```
8-
$ helm install drycc/workflow --namespace drycc --set global.use_ingress=true,controller.platform_domain=drycc.cc
8+
$ helm install drycc/workflow --namespace drycc --set ingress.enabled=true,controller.platform_domain=drycc.cc
99
```
1010

1111
Where `controller.platform_domain` is a **required** parameter that is traditionally not required for Workflow that is explained in the next section. In this example we are using `drycc.cc` for `$hostname`.
@@ -45,7 +45,7 @@ drycc-workflow-manager-68nu6 1/1 Running 0 5m
4545

4646
## Install a Kubernetes Ingress Controller
4747

48-
Now that Workflow has been deployed with the `global.use_ingress` flag set to `true`, we will need a Kubernetes ingress controller in place to begin routing traffic.
48+
Now that Workflow has been deployed with the `ingress.enable` flag set to `true`, we will need a Kubernetes ingress controller in place to begin routing traffic.
4949

5050
Here is an example of how to use [traefik](https://traefik.io/) as an ingress controller for Workflow. Of course, you are welcome to use any controller you wish.
5151

0 commit comments

Comments
 (0)