Skip to content

Commit 97faa6d

Browse files
authored
Merge pull request #518 from Codaisseur/improve-docs-on-registry-port-config
Improve docs on PORT config when using a private registry
2 parents 53f5134 + b6a7741 commit 97faa6d

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

src/applications/using-docker-images.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ In order to deploy Docker images, they must conform to the following requirement
2727
* The Dockerfile must use the `CMD` directive to define the default process that will run within the container.
2828
* The Docker image must contain [bash](https://www.gnu.org/software/bash/) to run processes.
2929

30+
!!! note
31+
Note that if you are using a private registry of any kind (`gcr` or other) the application environment must include a `$PORT` config variable that matches the `EXPOSE`'d port, example: `deis config:set PORT=5000`. See [Configuring Registry](../installing-workflow/configuring-registry/#configuring-off-cluster-private-registry) for more info.
3032

3133
## Create an Application
3234

src/applications/using-dockerfiles.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Deis supports deploying applications via Dockerfiles. A [Dockerfile][] automate
44
Dockerfiles are incredibly powerful but require some extra work to define your exact application runtime environment.
55

66
## Add SSH Key
7-
7+
88
For **Dockerfile** based application deploys via `git push`, Deis Workflow identifies users via SSH keys. SSH keys are pushed to the platform and must be unique to each user.
99

1010
- See [this document](../users/ssh-keys.md/#generate-an-ssh-key) for instructions on how to generate an SSH key.
@@ -36,6 +36,9 @@ In order to deploy Dockerfile applications, they must conform to the following r
3636
* The Dockerfile must use the `CMD` directive to define the default process that will run within the container.
3737
* The Docker image must contain [bash](https://www.gnu.org/software/bash/) to run processes.
3838

39+
!!! note
40+
Note that if you are using a private registry of any kind (`gcr` or other) the application environment must include a `$PORT` config variable that matches the `EXPOSE`'d port, example: `deis config:set PORT=5000`. See [Configuring Registry](../installing-workflow/configuring-registry/#configuring-off-cluster-private-registry) for more info.
41+
3942

4043
## Create an Application
4144

0 commit comments

Comments
 (0)