Skip to content

Commit 22a74fa

Browse files
author
Matthew Fisher
authored
Merge pull request #686 from bacongobbler/optimize-base64
ref(upgrading-workflow): use -w 0 flag when base64 encoding
2 parents 70c6b3e + 88f7007 commit 22a74fa

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/installing-workflow/configuring-object-storage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Operators should configure object storage by editing the Helm values file before
4444
All values will be automatically (base64) encoded _except_ the `key_json` values under `gcs`/`gcr`. These must be base64-encoded. This is to support cleanly passing said encoded text via `helm --set` cli functionality rather than attempting to pass the raw JSON data. For example:
4545

4646
$ helm install workflow --namespace deis \
47-
--set global.storage=gcs,gcs.key_json="$(cat /path/to/gcs_creds.json | base64 | tr -d '[:space:]')"
47+
--set global.storage=gcs,gcs.key_json="$(cat /path/to/gcs_creds.json | base64 -w 0)"
4848

4949
You are now ready to run `helm install deis/workflow --namespace deis -f values.yaml` using your desired object storage.
5050

src/managing-workflow/upgrading-workflow.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ $ helm upgrade <release-name> deis/workflow
3737
**Note:** If using off-cluster object storage on [gcs](https://cloud.google.com/storage/) and/or off-cluster registry using [gcr](https://cloud.google.com/container-registry/) and intending to upgrade from a pre-`v2.10.0` chart to `v2.10.0` or greater, the `key_json` values will now need to be pre-base64-encoded. Therefore, assuming the rest of the custom/off-cluster values are defined in the existing `values.yaml` used for previous installs, the following may be run:
3838

3939
```
40-
$ B64_KEY_JSON="$(cat ~/path/to/key.json | base64 | tr -d '[:space:]')"
40+
$ B64_KEY_JSON="$(cat ~/path/to/key.json | base64 -w 0)"
4141
$ helm upgrade <release_name> deis/workflow -f values.yaml --set gcs.key_json="${B64_KEY_JSON}",registry-token-refresher.gcr.key_json="${B64_KEY_JSON}"
4242
```
4343

0 commit comments

Comments
 (0)