Skip to content

Commit fa708c2

Browse files
committed
Merge pull request #334 from mboersma/no-slash
fix(controller): do not require slash at the end of `GET /v2/users`
2 parents 926af04 + 084d4d4 commit fa708c2

2 files changed

Lines changed: 10 additions & 13 deletions

File tree

rootfs/api/tests/test_users.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,23 +11,20 @@ class TestUsers(TestCase):
1111
fixtures = ['tests.json']
1212

1313
def test_super_user_can_list(self):
14-
url = '/v2/users/'
15-
1614
user = User.objects.get(username='autotest')
1715
token = Token.objects.get(user=user)
1816

19-
response = self.client.get(url,
20-
HTTP_AUTHORIZATION='token {}'.format(token))
21-
22-
self.assertEqual(response.status_code, 200)
23-
self.assertEqual(len(response.data['results']), 3)
17+
for url in ['/v2/users', '/v2/users/']:
18+
response = self.client.get(url,
19+
HTTP_AUTHORIZATION='token {}'.format(token))
20+
self.assertEqual(response.status_code, 200)
21+
self.assertEqual(len(response.data['results']), 3)
2422

2523
def test_non_super_user_cannot_list(self):
26-
url = '/v2/users/'
27-
2824
user = User.objects.get(username='autotest2')
2925
token = Token.objects.get(user=user)
3026

31-
response = self.client.get(url,
32-
HTTP_AUTHORIZATION='token {}'.format(token))
33-
self.assertEqual(response.status_code, 403)
27+
for url in ['/v2/users', '/v2/users/']:
28+
response = self.client.get(url,
29+
HTTP_AUTHORIZATION='token {}'.format(token))
30+
self.assertEqual(response.status_code, 403)

rootfs/api/urls.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,5 +103,5 @@
103103
url(r'^certs/?',
104104
views.CertificateViewSet.as_view({'get': 'list', 'post': 'create'})),
105105
# list users
106-
url(r'^users/', views.UserView.as_view({'get': 'list'})),
106+
url(r'^users/?', views.UserView.as_view({'get': 'list'})),
107107
]

0 commit comments

Comments
 (0)