feat(*): add make test-style targets

This gives us an opporunity to run code checkers and linters as part
of testing, as we used to on travis-ci.org. By default, unit tests
will check code syntax and style first.

Author: mboersma

client/Makefile

@@ -13,3 +13,10 @@ clean:
 
 client:
 	pyinstaller deis.spec
+
+setup-venv:
+	@if [ ! -d venv ]; then virtualenv venv; fi
+	venv/bin/pip install -q flake8==2.2.2
+
+test-style: setup-venv
+	venv/bin/flake8

client/setup.cfg

@@ -1,2 +1,7 @@
 [sdist]
 formats = zip,gztar
+
+[flake8]
+max-line-length = 99
+exclude = build,dist,venv
+max-complexity = 12

controller/Makefile

@@ -41,14 +41,16 @@ coverage:
 	coverage run manage.py test --noinput api
 	coverage html
 
-flake8:
-	flake8
-
 test: test-unit test-functional
 
-test-unit:
+setup-venv:
 	@if [ ! -d venv ]; then virtualenv venv; fi
 	venv/bin/pip install -q -r requirements.txt -r dev_requirements.txt
+
+test-style: setup-venv
+	venv/bin/flake8
+
+test-unit: setup-venv test-style
 	venv/bin/python manage.py test --noinput api
 
 test-functional:

controller/dev_requirements.txt

@@ -19,9 +19,7 @@ coverage>=3.7.1
 docutils>=0.12
 
 # Run "make flake8" to check python syntax and style
-flake8==2.1.0
-pep8==1.4.6
-pyflakes==0.7.3
+flake8==2.2.2
 
 # Used for mocking endpoints
 mock==1.0.1

controller/setup.cfg

@@ -1,4 +1,4 @@
 [flake8]
 max-line-length = 99
-exclude = */api/migrations/*,*/api/south_migrations/*,*/build/*,*/venv/*,*/virtualenv/*,*/scheduler/*,*/templates/*
+exclude = api/migrations,api/south_migrations,templates,venv
 max-complexity = 12

logger/Makefile

@@ -29,7 +29,19 @@ full-clean: clean
 
 test: test-unit test-functional
 
-test-unit:
+setup-root-gotools:
+	sudo GOPATH=/tmp/tmpGOPATH go get -u -v code.google.com/p/go.tools/cmd/cover
+	sudo GOPATH=/tmp/tmpGOPATH go get -u -v code.google.com/p/go.tools/cmd/vet
+	sudo rm -rf /tmp/tmpGOPATH
+
+setup-gotools:
+	go get -v github.com/golang/lint/golint
+
+test-style:
+	go vet -x ./...
+	-golint .
+
+test-unit: test-style
 	go test -v -cover ./syslog
 
 test-functional:

tests/Makefile

@@ -1,10 +1,10 @@
 test: test-smoke
 
-test-smoke:
+test-smoke: test-style
 	GOPATH=$(CURDIR)/_vendor:$(GOPATH) \
 		go test -tags integration -short -v -run TestSmoke
 
-test-full:
+test-full: test-style
 	GOPATH=$(CURDIR)/_vendor:$(GOPATH) \
 		go test -tags integration -v -run TestGlobal
 	GOPATH=$(CURDIR)/_vendor:$(GOPATH) \
@@ -26,6 +26,18 @@ test-full:
 	GOPATH=$(CURDIR)/_vendor:$(GOPATH) \
 		go test -tags integration -v -run TestReleases
 
+setup-root-gotools:
+	sudo GOPATH=/tmp/tmpGOPATH go get -u -v code.google.com/p/go.tools/cmd/cover
+	sudo GOPATH=/tmp/tmpGOPATH go get -u -v code.google.com/p/go.tools/cmd/vet
+	sudo rm -rf /tmp/tmpGOPATH
+
+setup-gotools:
+	go get -v github.com/golang/lint/golint
+
+test-style:
+	go vet -x ./...
+	-golint *.go dockercli etcdutils mock utils
+
 nuke_from_orbit:
 	-docker kill `docker ps -q`
 	-docker rm `docker ps -a -q`