Skip to content

Commit d8228df

Browse files
author
Gabriel Monroy
committed
Merge pull request #2040 from johanneswuerbach/patch-6
fix(router): Use official javascript content type
2 parents b72e204 + 481fe92 commit d8228df

3 files changed

Lines changed: 14 additions & 11 deletions

File tree

docs/managing_deis/router_settings.rst

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ Settings used by router
3030
---------------------------
3131
The following etcd keys are used by the router component.
3232

33-
======================================= =============================================================================================================================================================================================
33+
======================================= ==================================================================================================================================================================================================================================================================================================================================
3434
setting description
35-
======================================= =============================================================================================================================================================================================
35+
======================================= ==================================================================================================================================================================================================================================================================================================================================
3636
/deis/domains/* domain configuration for applications (set by controller)
3737
/deis/services/* application configuration (set by application unit files)
3838
/deis/builder/host host of the builder component (set by builder)
@@ -48,13 +48,14 @@ setting description
4848
/deis/router/controller/timeout/read proxy_read_timeout for deis-controller (default: 20m)
4949
/deis/router/controller/timeout/send proxy_send_timeout for deis-controller (default: 20m)
5050
/deis/router/gzip nginx gzip setting (default: on)
51-
/deis/router/gzipHttpVersion nginx gzipHttpVersion setting (default: 1.0)
52-
/deis/router/gzipCompLevel nginx gzipCompLevel setting (default: 2)
51+
/deis/router/gzipHttpVersion nginx gzipHttpVersion setting (default: 1.1)
52+
/deis/router/gzipCompLevel nginx gzipCompLevel setting (default: 5)
5353
/deis/router/gzipProxied nginx gzipProxied setting (default: any)
5454
/deis/router/gzipVary nginx gzipVary setting (default: on)
5555
/deis/router/gzipDisable nginx gzipDisable setting (default: "msie6")
56-
/deis/router/gzipTypes nginx gzipTypes setting (default: "application/x-javascript application/xhtml+xml application/xml application/xml+rss application/json text/css text/javascript text/plain text/xml")
57-
======================================= =============================================================================================================================================================================================
56+
/deis/router/gzipTypes nginx gzipTypes setting (default: "application/atom+xml application/javascript application/json application/rss+xml application/vnd.ms-fontobject application/x-font-ttf application/x-web-app-manifest+json application/xhtml+xml application/xml font/opentype image/svg+xml image/x-icon text/css text/plain text/x-component")
57+
/deis/router/gzipMinLength nginx gzipMinLength setting (default: 256)
58+
======================================= ==================================================================================================================================================================================================================================================================================================================================
5859

5960
Using a custom router image
6061
---------------------------

router/bin/boot

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,13 @@ etcd_safe_mkdir /deis/services
3838
etcd_safe_mkdir /deis/domains
3939
etcd_safe_mkdir /deis/builder
4040
etcd_set_default gzip on
41-
etcd_set_default gzipHttpVersion 1.0
42-
etcd_set_default gzipCompLevel 2
41+
etcd_set_default gzipHttpVersion 1.1
42+
etcd_set_default gzipCompLevel 5
43+
etcd_set_default gzipMinLength 256
4344
etcd_set_default gzipProxied any
4445
etcd_set_default gzipVary on
4546
etcd_set_default gzipDisable "\"msie6\""
46-
etcd_set_default gzipTypes "application/x-javascript application/xhtml+xml application/xml application/xml+rss application/json text/css text/javascript text/plain text/xml"
47+
etcd_set_default gzipTypes "application/atom+xml application/javascript application/json application/rss+xml application/vnd.ms-fontobject application/x-font-ttf application/x-web-app-manifest+json application/xhtml+xml application/xml font/opentype image/svg+xml image/x-icon text/css text/plain text/x-component"
4748

4849
# spawn the service in the background
4950
echo "Starting Nginx..."

router/templates/nginx.conf

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
daemon off;
33

44
user www-data;
5-
worker_processes 4;
5+
worker_processes auto;
66
pid /run/nginx.pid;
77

88
events {
@@ -26,10 +26,11 @@ http {
2626
gzip_comp_level {{ .deis_router_gzipCompLevel }};
2727
gzip_disable {{ .deis_router_gzipDisable }};
2828
gzip_http_version {{ .deis_router_gzipHttpVersion }};
29+
gzip_min_length {{ .deis_router_gzipMinLength }};
2930
gzip_types {{ .deis_router_gzipTypes }};
3031
gzip_proxied {{ .deis_router_gzipProxied }};
3132
gzip_vary {{ .deis_router_gzipVary }};{{ end }}
32-
33+
3334
client_max_body_size {{ or (.deis_router_bodySize) "1m" }};
3435

3536
# send logs to STDOUT so they can be seen using 'docker logs'

0 commit comments

Comments
 (0)