Skip to content

Commit d7dba1f

Browse files
committed
tests(etcd): update coreos/etcd to v0.4.4
1 parent 0c59156 commit d7dba1f

3 files changed

Lines changed: 40 additions & 15 deletions

File tree

logger/tests/loggerComponent_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ func TestBuild(t *testing.T) {
3737
servicePort := utils.GetRandomPort()
3838
fmt.Println("UUID for the session logger Test :" + testSessionUID)
3939
dockercliutils.RunEtcdTest(t, testSessionUID, etcdPort)
40-
fmt.Println("starting logger componenet test:")
40+
fmt.Println("starting logger component test:")
4141
runDeisLoggerTest(t, testSessionUID, etcdPort, servicePort)
4242
dockercliutils.DeisServiceTest(
4343
t, "deis-logger-"+testSessionUID, servicePort, "udp")

tests/dockercliutils/dockercliutils.go

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,16 @@ func RunContainer(t *testing.T, cli *client.DockerCli, args ...string) {
175175
fmt.Println("Running docker container :" + args[1])
176176
err := cli.CmdRun(args...)
177177
if err != nil {
178-
if !((strings.Contains(
179-
fmt.Sprintf("%s", err), "read/write on closed pipe")) || (strings.Contains(fmt.Sprintf("%s", err), "Code: -1")) || (strings.Contains(fmt.Sprintf("%s", err), "Code: 2"))) {
180-
t.Fatalf("Run Docker container failed %s", err)
178+
// Ignore certain errors we see in io handling.
179+
switch msg := err.Error(); {
180+
case strings.Contains(msg, "read/write on closed pipe"):
181+
return
182+
case strings.Contains(msg, "Code: -1"):
183+
return
184+
case strings.Contains(msg, "Code: 2"):
185+
return
186+
default:
187+
t.Fatalf("RunContainer failed: %v", err)
181188
}
182189
}
183190
}
@@ -334,22 +341,22 @@ func GetImageID(t *testing.T, repo string) string {
334341

335342
// RunEtcdTest starts an etcd docker container for testing.
336343
func RunEtcdTest(t *testing.T, uid string, port string) {
337-
//docker run -t -i --name=deis-etcd -p 4001:4001 -e HOST_IP=172.17.8.100 -e ETCD_ADDR=172.17.8.100:4001 --entrypoint=/bin/bash phife.atribecalledchris.com:5000/deis/etcd:0.3.0 -c /usr/local/bin/etcd
344+
//docker run -t -i --name=deis-etcd -p 4001:4001 -e HOST_IP=172.17.8.100
345+
// -e ETCD_ADDR=172.17.8.100:4001
346+
// --entrypoint=/bin/bash phife.atribecalledchris.com:5000/deis/etcd:0.3.0
347+
// -c /usr/local/bin/etcd
338348
cli, stdout, stdoutPipe := GetNewClient()
339349
done2 := make(chan bool, 1)
340-
var imageID string
341-
var imageTag string
342350
IPAddress := utils.GetHostIPAddress()
343351
go func() {
344-
PullImage(t, cli, "deisreleases/etcd:test")
345-
imageID = GetImageID(t, "deisreleases/etcd")
346-
imageTag = "deis/etcd:" + uid
347-
cli.CmdTag(imageID, imageTag)
352+
PullImage(t, cli, "deis/test-etcd:latest")
348353
done2 <- true
349-
RunContainer(t, cli, "--name", "deis-etcd-"+uid,
350-
"-p", port+":"+port, "-e", "HOST_IP="+IPAddress,
351-
"-e", "ETCD_ADDR="+IPAddress+":"+port, "--entrypoint=/bin/bash",
352-
imageTag, "-c", "/usr/local/bin/etcd")
354+
RunContainer(t, cli,
355+
"--name", "deis-etcd-"+uid,
356+
"-p", port+":"+port,
357+
"-e", "HOST_IP="+IPAddress,
358+
"-e", "ETCD_ADDR="+IPAddress+":"+port,
359+
"deis/test-etcd:latest")
353360
}()
354361
go func() {
355362
<-done2

tests/etcdutils/Dockerfile

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
FROM ubuntu:12.04
2+
MAINTAINER Matt Boersma <matt@opdemand.com>
3+
4+
# Install prerequisites: wget, git, and go.
5+
RUN apt-get update -q && DEBIAN_FRONTEND=noninteractive apt-get install -qy wget git-core
6+
RUN wget -qO- https://storage.googleapis.com/golang/go1.3.linux-amd64.tar.gz | tar -C /usr/local -xz
7+
ENV PATH /usr/local/go/bin:$PATH
8+
9+
# Build etcd v0.4.3. Keep this in sync with Deis' CoreOS version.
10+
RUN git clone -b v0.4.3 -q https://github.com/coreos/etcd.git /opt/etcd
11+
RUN cd /opt/etcd && ./build
12+
13+
# Download latest stable etcdctl. Keep this in sync with Deis' CoreOS version.
14+
ADD https://s3-us-west-2.amazonaws.com/opdemand/etcdctl-v0.4.4 /usr/local/bin/etcdctl
15+
RUN chmod +x /usr/local/bin/etcdctl
16+
17+
EXPOSE 4001 7001
18+
CMD ["/opt/etcd/bin/etcd"]

0 commit comments

Comments
 (0)