fix(controller): retrieve logs via GET request

Author: Matthew Fisher

client/deis.py

@@ -621,7 +621,7 @@ def apps_logs(self, args):
         app = args.get('--app')
         if not app:
             app = self._session.app
-        response = self._dispatch('post',
+        response = self._dispatch('get',
                                   "/api/apps/{}/logs".format(app))
         if response.status_code == requests.codes.ok:  # @UndefinedVariable
             # strip the last newline character

controller/api/tests/test_app.py

@@ -79,13 +79,13 @@ def test_app_actions(self):
         if os.path.exists(path):
             os.remove(path)
         url = '/api/apps/{app_id}/logs'.format(**locals())
-        response = self.client.post(url)
+        response = self.client.get(url)
         self.assertEqual(response.status_code, 204)
         self.assertEqual(response.data, 'No logs for {}'.format(app_id))
         # write out some fake log data and try again
         with open(path, 'a') as f:
             f.write(FAKE_LOG_DATA)
-        response = self.client.post(url)
+        response = self.client.get(url)
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data, FAKE_LOG_DATA)
         os.remove(path)
@@ -107,7 +107,7 @@ def test_app_release_notes_in_logs(self):
         app_id = response.data['id']  # noqa
         path = os.path.join(settings.DEIS_LOG_DIR, app_id + '.log')
         url = '/api/apps/{app_id}/logs'.format(**locals())
-        response = self.client.post(url)
+        response = self.client.get(url)
         self.assertIn('autotest created initial release', response.data)
         self.assertEqual(response.status_code, 200)
         # delete file for future runs
@@ -170,7 +170,7 @@ def test_admin_can_manage_other_apps(self):
         self.assertEqual(response.status_code, 200)
         # check app logs
         url = '/api/apps/{app_id}/logs'.format(**locals())
-        response = self.client.post(url)
+        response = self.client.get(url)
         self.assertEqual(response.status_code, 200)
         self.assertIn('autotest2 created initial release', response.data)
         # run one-off commands

controller/api/urls.py

@@ -119,7 +119,7 @@
   See also
   :meth:`AppViewSet.scale() <api.views.AppViewSet.scale>`
 
-.. http:post:: /api/apps/(string:id)/logs/
+.. http:get:: /api/apps/(string:id)/logs/
 
   See also
   :meth:`AppViewSet.logs() <api.views.AppViewSet.logs>`
@@ -276,7 +276,7 @@
     url(r'^apps/(?P<id>{})/scale/?'.format(settings.APP_URL_REGEX),
         views.AppViewSet.as_view({'post': 'scale'})),
     url(r'^apps/(?P<id>{})/logs/?'.format(settings.APP_URL_REGEX),
-        views.AppViewSet.as_view({'post': 'logs'})),
+        views.AppViewSet.as_view({'get': 'logs'})),
     url(r'^apps/(?P<id>{})/run/?'.format(settings.APP_URL_REGEX),
         views.AppViewSet.as_view({'post': 'run'})),
     # apps sharing