Skip to content

Commit d2c97da

Browse files
author
Matthew Fisher
committed
Merge pull request #1521 from deis/1354-delete-logs
fix(controller): remove application logs on delete
2 parents aa98312 + 987b2d5 commit d2c97da

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

controller/api/models.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,10 @@ def create(self, *args, **kwargs):
139139
def delete(self, *args, **kwargs):
140140
for c in self.container_set.all():
141141
c.destroy()
142+
# delete application logs stored by deis/logger
143+
path = os.path.join(settings.DEIS_LOG_DIR, self.id + '.log')
144+
if os.path.exists(path):
145+
os.remove(path)
142146
return super(App, self).delete(*args, **kwargs)
143147

144148
def deploy(self, release, initial=False):

controller/bin/boot

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ done
4848

4949
cd /app
5050

51+
# give the deis user permissions to write to the volume mount
52+
chown -R deis:deis /var/log/deis
53+
5154
# run an idempotent database migration
5255
sudo -E -u deis ./manage.py syncdb --migrate --noinput
5356

0 commit comments

Comments
 (0)