Merge pull request #2092 from carmstrong/store_volume

feat(*): shared volume support for controller/logger (adds store-metadata and store-volume)

Author: Gabriel Monroy

controller/api/static/500.html

@@ -26,7 +26,7 @@
   <div class="container">
     <div class="row">
     	<h1>Internal Server Error</h1>
-    	<p>See /var/log/deis for details</p>
+    	<p>See /data for details</p>
     </div> <!-- .row -->
   </div> <!-- .main_section container-->
 

controller/bin/boot

@@ -51,8 +51,8 @@ done
 
 cd /app
 
-# give the deis user permissions to write to the volume mount
-chown -R deis:deis /var/log/deis
+mkdir -p /data/logs
+chmod 777 /data/logs
 
 # run an idempotent database migration
 sudo -E -u deis ./manage.py syncdb --migrate --noinput

controller/build.sh

@@ -1,9 +1,9 @@
 #!/usr/bin/env bash
 
 if [[ -z $DOCKER_BUILD ]]; then
-  echo 
+  echo
   echo "Note: this script is intended for use by the Dockerfile and not as a way to build the controller locally"
-  echo 
+  echo
   exit 1
 fi
 
@@ -28,9 +28,6 @@ mkdir -p /app && chown -R deis:deis /app
 # create directory for confd templates
 mkdir -p /templates && chown -R deis:deis /templates
 
-# create directory for logs
-mkdir -p /var/log/deis && chown -R deis:deis /var/log/deis
-
 # install dependencies
 pip install -r /app/requirements.txt
 

controller/templates/confd_settings.py

@@ -38,7 +38,7 @@
 CACHE_URL = 'redis://{{ .deis_cache_host }}:{{ .deis_cache_port }}/0'
 
 # move log directory out of /app/deis
-DEIS_LOG_DIR = '/var/log/deis'
+DEIS_LOG_DIR = '/data/logs'
 
 {{ if .deis_controller_registrationEnabled }}
 REGISTRATION_ENABLED = bool({{ .deis_controller_registrationEnabled }})

controller/tests/controller_test.go

@@ -29,10 +29,13 @@ func TestController(t *testing.T) {
 		"/deis/domains",
 	}
 	tag, etcdPort := utils.BuildTag(), utils.RandomPort()
+
+	//start etcd container
 	etcdName := "deis-etcd-" + tag
 	cli, stdout, stdoutPipe := dockercli.NewClient()
 	dockercli.RunTestEtcd(t, etcdName, etcdPort)
 	defer cli.CmdRm("-f", etcdName)
+
 	handler := etcdutils.InitEtcd(setdir, setkeys, etcdPort)
 	etcdutils.PublishEtcd(t, handler)
 	mock.RunMockDatabase(t, tag, etcdPort, utils.RandomPort())

deisctl/README.md

@@ -79,8 +79,6 @@ $ deisctl install platform
 ■ ● ▴ Installing Deis...
 ▴ ■ ●
 
-Data containers...
-deis-logger-data.service: loaded
 Logging subsystem...
 deis-logger.service: loaded
 Storage subsystem...
@@ -105,8 +103,6 @@ $ deisctl start platform
 ■ ● ▴ Starting Deis...
 ▴ ■ ●
 
-Data containers...
-deis-logger-data.service: exited
 Logging subsystem...
 deis-logger.service: running
 deis-logspout.service: running
@@ -186,7 +182,6 @@ deis-builder.service		f936b7a5.../172.17.8.100	loaded	active	running
 deis-cache.service  		f936b7a5.../172.17.8.100	loaded	active	running
 deis-controller.service	    f936b7a5.../172.17.8.100	loaded	active	running
 deis-database.service		f936b7a5.../172.17.8.100	loaded	active	running
-deis-logger-data.service	f936b7a5.../172.17.8.100	loaded	active	exited
 deis-logger.service	    	f936b7a5.../172.17.8.100	loaded	active	running
 deis-registry.service		f936b7a5.../172.17.8.100	loaded	active	running
 deis-router@1.service		f936b7a5.../172.17.8.100	loaded	active	running

deisctl/backend/fleet/create.go

@@ -2,7 +2,6 @@ package fleet
 
 import (
 	"fmt"
-	"strings"
 	"sync"
 
 	"github.com/coreos/fleet/job"
@@ -62,11 +61,7 @@ func (c *FleetClient) createUnitFile(target string) (unitName string, uf *unit.U
 	if err != nil {
 		return
 	}
-	if strings.HasSuffix(component, "-data") {
-		unitName, uf, err = c.createDataUnit(component)
-	} else {
-		unitName, uf, err = c.createServiceUnit(component, num)
-	}
+	unitName, uf, err = c.createServiceUnit(component, num)
 	if err != nil {
 		return unitName, uf, err
 	}
@@ -85,21 +80,3 @@ func (c *FleetClient) createServiceUnit(component string, num int) (name string,
 	}
 	return name, uf, nil
 }
-
-// Create data container unit
-func (c *FleetClient) createDataUnit(component string) (name string, uf *unit.UnitFile, err error) {
-	name, err = formatUnitName(component, 0)
-	if err != nil {
-		return
-	}
-	machineID, err := randomMachineID(c)
-	if err != nil {
-		return
-	}
-	uf, err = NewDataUnit(component, machineID)
-	if err != nil {
-		return
-	}
-	return name, uf, nil
-
-}

deisctl/backend/fleet/fleet.go

@@ -18,16 +18,3 @@ func NewClient() (*FleetClient, error) {
 	cAPI = client
 	return &FleetClient{Fleet: client}, nil
 }
-
-// randomMachineID return a random machineID from the Fleet cluster
-func randomMachineID(c *FleetClient) (machineID string, err error) {
-	machineState, err := c.Fleet.Machines()
-	if err != nil {
-		return "", err
-	}
-	var machineIDs []string
-	for _, ms := range machineState {
-		machineIDs = append(machineIDs, ms.ID)
-	}
-	return randomValue(machineIDs), nil
-}

deisctl/backend/fleet/start.go

@@ -2,7 +2,6 @@ package fleet
 
 import (
 	"fmt"
-	"strings"
 	"sync"
 	"time"
 
@@ -34,12 +33,7 @@ func doStart(c *FleetClient, target string, wg *sync.WaitGroup, outchan chan str
 	}
 
 	requestState := "launched"
-	var desiredState string
-	if strings.Contains(name, "-data.service") {
-		desiredState = "exited"
-	} else {
-		desiredState = "running"
-	}
+	desiredState := "running"
 
 	if err := c.Fleet.SetUnitTargetState(name, requestState); err != nil {
 		errchan <- err

deisctl/backend/fleet/unit.go

@@ -24,18 +24,9 @@ func (c *FleetClient) Units(target string) (units []string, err error) {
 	if err != nil {
 		return
 	}
-	if strings.HasSuffix(target, "-data") {
-		for _, u := range allUnits {
-			if strings.Contains(u.Name, target) {
-				units = []string{u.Name}
-				return
-			}
-		}
-	} else {
-		for _, u := range allUnits {
-			if strings.Contains(u.Name, target) && !strings.HasSuffix(u.Name, "-data.service") {
-				units = append(units, u.Name)
-			}
+	for _, u := range allUnits {
+		if strings.Contains(u.Name, target) {
+			units = append(units, u.Name)
 		}
 	}
 	if len(units) == 0 {
@@ -84,22 +75,6 @@ func NewUnit(component string) (uf *unit.UnitFile, err error) {
 	return
 }
 
-// NewDataUnit takes a component type and returns a Fleet unit
-// that is hard-scheduled to a machine ID
-func NewDataUnit(component string, machineID string) (uf *unit.UnitFile, err error) {
-	template, err := readTemplate(component)
-	if err != nil {
-		return
-	}
-	// replace CHANGEME with random machineID
-	replaced := strings.Replace(string(template), "CHANGEME", machineID, 1)
-	uf, err = unit.NewUnitFile(replaced)
-	if err != nil {
-		return
-	}
-	return
-}
-
 // formatUnitName returns a properly formatted systemd service name
 // using the given component type and number
 func formatUnitName(component string, num int) (unitName string, err error) {