Skip to content

Commit cdd6319

Browse files
committed
Merge pull request #537 from opdemand/474-atomic-requests
Enabled Django ATOMIC_REQUESTS, fixes #474.
2 parents 7f3685c + fc5b8b3 commit cdd6319

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

api/views.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from Crypto.PublicKey import RSA
1010
from django.contrib.auth.models import AnonymousUser
1111
from django.contrib.auth.models import User
12-
from django.db import transaction
1312
from django.utils import timezone
1413
from guardian.shortcuts import assign_perm
1514
from guardian.shortcuts import get_objects_for_user
@@ -626,11 +625,10 @@ def rollback(self, request, *args, **kwargs):
626625
if version < 1:
627626
return Response(status=status.HTTP_404_NOT_FOUND)
628627
prev = app.release_set.get(version=version)
629-
with transaction.atomic():
630-
summary = "{} rolled back to v{}".format(request.user, version)
631-
app.release_set.create(owner=request.user, version=last_version + 1,
632-
build=prev.build, config=prev.config,
633-
summary=summary)
628+
summary = "{} rolled back to v{}".format(request.user, version)
629+
app.release_set.create(owner=request.user, version=last_version + 1,
630+
build=prev.build, config=prev.config,
631+
summary=summary)
634632
# publish release to registry as new docker image
635633
if settings.REGISTRY_URL:
636634
repository_path = "{}/{}".format(app.owner.username, app.id)

deis/settings.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -329,3 +329,6 @@
329329
from .local_settings import * # @UnusedWildImport # noqa
330330
except ImportError:
331331
pass
332+
333+
# Ensure that atomic DB transactions per view are enabled
334+
DATABASES['default']['ATOMIC_REQUESTS'] = True

0 commit comments

Comments
 (0)