fix(test-style): make fmt fail style-test and fix existing formatting errors (#135)

Author: Joshua-Anderson

Makefile

@@ -25,9 +25,9 @@ GCS_BUCKET ?= "gs://workflow-cli"
 
 GO_FILES = $(wildcard *.go)
 GO_LDFLAGS = -ldflags "-s -X ${repo_path}/version.BuildVersion=${VERSION}"
-GO_PACKAGES = cmd parser $(wildcard pkg/*)
+GO_PACKAGES = cmd parser cli $(wildcard pkg/*)
 GO_PACKAGES_REPO_PATH = $(addprefix $(repo_path)/,$(GO_PACKAGES))
-GOFMT = gofmt -e -l -s
+GOFMT = gofmtresult=$$(gofmt -e -l -s ${GO_FILES} ${GO_PACKAGES}); if [[ -n $$gofmtresult ]]; then echo "gofmt errors found in the following files: $${gofmtresult}"; false; fi;
 GOTEST = go test --cover --race -v
 
 # The tag of the commit
@@ -96,7 +96,8 @@ setup-gotools:
 test: test-style test-unit
 
 test-style:
-	${DEV_ENV_CMD} sh -c '${GOFMT} ${GO_FILES} ${GO_PACKAGES} && go vet $(repo_path) $(GO_PACKAGES_REPO_PATH)'
+	${DEV_ENV_CMD} bash -c '${GOFMT}'
+	${DEV_ENV_CMD} sh -c 'go vet $(repo_path) $(GO_PACKAGES_REPO_PATH)'
 	@for i in $(addsuffix /...,$(GO_PACKAGES)); do \
 		${DEV_ENV_CMD} golint $$i; \
 	done

cli/cli.go

@@ -1,5 +1,6 @@
 package cli
 
+// Shortcuts is a map of all the shortcuts supported by the CLI
 var Shortcuts = map[string]string{
 	"create":         "apps:create",
 	"destroy":        "apps:destroy",

cmd/apps_test.go

@@ -24,11 +24,11 @@ type expandURLCases struct {
 
 func TestExpandUrl(t *testing.T) {
 	checks := []expandURLCases{
-		expandURLCases{
+		{
 			Input:    "test.com",
 			Expected: "test.com",
 		},
-		expandURLCases{
+		{
 			Input:    "test",
 			Expected: "test.foo.com",
 		},

cmd/keys_test.go

@@ -132,19 +132,19 @@ type chooseKeyCases struct {
 
 func TestChooseKey(t *testing.T) {
 	testKeys := []api.KeyCreateRequest{
-		api.KeyCreateRequest{},
+		{},
 	}
 
 	checks := []chooseKeyCases{
-		chooseKeyCases{
+		{
 			Reader:   strings.NewReader("-1"),
 			Expected: "-1 is not a valid option",
 		},
-		chooseKeyCases{
+		{
 			Reader:   strings.NewReader("2"),
 			Expected: "2 is not a valid option",
 		},
-		chooseKeyCases{
+		{
 			Reader:   strings.NewReader("a"),
 			Expected: "a is not a valid integer",
 		},

cmd/ps.go

@@ -133,7 +133,7 @@ func parseType(target string, appID string) (string, string) {
 	psType, psName := "", ""
 
 	if strings.Contains(target, "-") {
-		replaced := strings.Replace(target, appID + "-", "", 1)
+		replaced := strings.Replace(target, appID+"-", "", 1)
 		parts := strings.Split(replaced, "-")
 		// the API requires the type, for now
 		// regex matches against how Deployment pod name is constructed

cmd/shortcuts_test.go

@@ -1,14 +1,13 @@
 package cmd
 
 import (
-  "testing"
+	"testing"
 )
 
-
 func TestShortcutsList(t *testing.T) {
 	t.Parallel()
 
-  expected := `create -> apps:create
+	expected := `create -> apps:create
 destroy -> apps:destroy
 info -> apps:info
 login -> auth:login
@@ -27,9 +26,9 @@ sharing:list -> perms:list
 sharing:remove -> perms:delete
 whoami -> auth:whoami
 `
-  actual := sortShortcuts()
-  if actual != expected {
-    t.Errorf("Expected %s, Got %s", expected, actual)
-  }
+	actual := sortShortcuts()
+	if actual != expected {
+		t.Errorf("Expected %s, Got %s", expected, actual)
+	}
 
 }