Skip to content

Commit a2166fa

Browse files
committed
ref(tests+database): set connection_timeout, increase polling interval, use db.Ping()
ref(tests+database) print cannot_connect_now error message for easier failure assessment
1 parent e2d8dbd commit a2166fa

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

database/tests/recovery_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
)
1313

1414
func OpenDeisDatabase(t *testing.T, host string, port string) *sql.DB {
15-
db, err := sql.Open("postgres", "postgres://deis:changeme123@"+host+":"+port+"/deis?sslmode=disable")
15+
db, err := sql.Open("postgres", "postgres://deis:changeme123@"+host+":"+port+"/deis?sslmode=disable&connect_timeout=4")
1616
if err != nil {
1717
t.Fatal(err)
1818
}
@@ -21,18 +21,18 @@ func OpenDeisDatabase(t *testing.T, host string, port string) *sql.DB {
2121
}
2222

2323
func WaitForDatabase(t *testing.T, db *sql.DB) {
24-
fmt.Printf("--- Waiting for pg to be ready")
24+
fmt.Println("--- Waiting for pg to be ready")
2525
for {
26-
_, err := db.Query("select 1")
26+
err := db.Ping()
2727
if err, ok := err.(*pq.Error); ok {
2828
if err.Code.Name() == "cannot_connect_now" {
29-
fmt.Printf(".")
30-
time.Sleep(500 * time.Millisecond)
29+
fmt.Println(err.Message)
30+
time.Sleep(1000 * time.Millisecond)
3131
continue
3232
}
3333
t.Fatal(err)
3434
}
35-
fmt.Printf("\n")
35+
fmt.Println("Ready")
3636
break
3737
}
3838
}

0 commit comments

Comments
 (0)