Merge pull request #2178 from aledbf/ref_tests_timeout

Gabriel Monroy · Gabriel Monroy · commit 9efda3319702 · 2014-10-19T13:36:10.000-06:00
ref(test): close the response body and indicate the status code.
diff --git a/tests/utils/itutils.go b/tests/utils/itutils.go
@@ -84,14 +84,15 @@ func GetGlobalConfig() *DeisTestConfig {
 
 func doCurl(url string) ([]byte, error) {
 	response, err := http.Get(url)
+	defer response.Body.Close()
 	if err != nil {
 		return nil, err
 	}
 
 	body, err := ioutil.ReadAll(response.Body)
 
 	if !strings.Contains(string(body), "Powered by Deis") {
-		return nil, fmt.Errorf("App not started")
+		return nil, fmt.Errorf("App not started (%d)", response.StatusCode)
 	}
 
 	return body, nil
@@ -117,7 +118,6 @@ func Curl(t *testing.T, params *DeisTestConfig) {
 		t.Fatal(err)
 	}
 	fmt.Println(string(body))
-
 }
 
 // AuthCancel tests whether `deis auth:cancel` destroys a user's account.

Original file line number	Diff line number	Diff line change
`@@ -84,14 +84,15 @@ func GetGlobalConfig() *DeisTestConfig {`
`84`	`84`
`85`	`85`	`func doCurl(url string) ([]byte, error) {`
`86`	`86`	`response, err := http.Get(url)`
	`87`	`+ defer response.Body.Close()`
`87`	`88`	`if err != nil {`
`88`	`89`	`return nil, err`
`89`	`90`	`}`
`90`	`91`
`91`	`92`	`body, err := ioutil.ReadAll(response.Body)`
`92`	`93`
`93`	`94`	`if !strings.Contains(string(body), "Powered by Deis") {`
`94`		`- return nil, fmt.Errorf("App not started")`
	`95`	`+ return nil, fmt.Errorf("App not started (%d)", response.StatusCode)`
`95`	`96`	`}`
`96`	`97`
`97`	`98`	`return body, nil`
`@@ -117,7 +118,6 @@ func Curl(t testing.T, params DeisTestConfig) {`
`117`	`118`	`t.Fatal(err)`
`118`	`119`	`}`
`119`	`120`	`fmt.Println(string(body))`
`120`		`-`
`121`	`121`	`}`
`122`	`122`
`123`	`123`	// AuthCancel tests whether `deis auth:cancel` destroys a user's account.