Skip to content

Commit 9ced3ff

Browse files
author
Matthew Fisher
committed
Merge pull request #3017 from ngpestelos/remove-build-image-from-Makefile
chore(builder, logger, logspout): remove unused references to BUILD_IMAGE
2 parents 1d26154 + 19125af commit 9ced3ff

3 files changed

Lines changed: 3 additions & 7 deletions

File tree

builder/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ include ../includes.mk
33
COMPONENT = builder
44
IMAGE = $(IMAGE_PREFIX)$(COMPONENT):$(BUILD_TAG)
55
DEV_IMAGE = $(DEV_REGISTRY)/$(IMAGE)
6-
BUILD_IMAGE := $(COMPONENT)-build
76
BINARIES := extract-domain extract-types extract-version generate-buildhook get-app-config get-app-values publish-release-controller yaml2json-procfile
87
BINARY_DEST_DIR := image/bin
98

logger/Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ include ../includes.mk
22

33
COMPONENT = logger
44
IMAGE = $(IMAGE_PREFIX)$(COMPONENT):$(BUILD_TAG)
5-
BUILD_IMAGE := $(COMPONENT)-build
65
DEV_IMAGE = $(DEV_REGISTRY)/$(IMAGE)
76
BINARY_DEST_DIR = image/bin
87

logspout/Makefile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,20 @@ include ../includes.mk
22

33
COMPONENT := logspout
44
DOCKER_IMAGE := deis/$(COMPONENT)
5-
BUILD_IMAGE := $(DOCKER_IMAGE)-build
65
RELEASE_IMAGE := $(DOCKER_IMAGE):$(BUILD_TAG)
76
DEV_DOCKER_IMAGE := $(DEV_REGISTRY)/$(RELEASE_IMAGE)
87

98
build: check-docker
109
GOOS=linux GOARCH=amd64 CGO_ENABLED=0 godep go build -a -v -ldflags '-s' -o image/logspout
1110
docker build -t $(RELEASE_IMAGE) image
1211

13-
clean: check-docker check-registry
12+
clean:
1413
rm -rf image/logspout
15-
docker rmi $(RELEASE_IMAGE) $(BUILD_IMAGE)
1614

17-
full-clean: check-docker check-registry
15+
full-clean:
1816
docker images -q $(DOCKER_IMAGE) | xargs docker rmi -f
19-
docker images -q $(BUILD_IMAGE) | xargs docker rmi -f
2017
docker images -q $(DEV_DOCKER_IMAGE) | xargs docker rmi -f
18+
docker images -q $(RELEASE_IMAGE) | xargs docker rmi -f
2119

2220
install: check-deisctl
2321
deisctl install $(COMPONENT)

0 commit comments

Comments
 (0)