Skip to content

Commit 9a9c40c

Browse files
Matthew Fishercarmstrong
authored andcommitted
fix(controller): do not deploy releases on domains
Heroku doesn't deploy a new release when you add a domain to an app. Neither should we.
1 parent 526cd06 commit 9a9c40c

2 files changed

Lines changed: 5 additions & 12 deletions

File tree

controller/api/models.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,6 @@ def scale(self, **kwargs): # noqa
209209
if to_remove:
210210
subtasks.append(tasks.stop_containers.s(to_remove))
211211
group(*subtasks).apply_async().join()
212-
_publish_domains(app=str(self), domains=list(self.domain_set.all()))
213212
log_event(self, msg)
214213
return changed
215214

@@ -543,6 +542,10 @@ class Domain(AuditedModel):
543542
def __str__(self):
544543
return self.domain
545544

545+
def create(self):
546+
_publish_domains(app=str(self.app), domains=list(self.app.domain_set.all()))
547+
msg = 'Domains deployed: ' + ' '.join(str(i) for i in self.app.domain_set.all())
548+
546549

547550
@python_2_unicode_compatible
548551
class Key(UuidAuditedModel):

controller/api/views.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -474,17 +474,7 @@ def create(self, request, *args, **kwargs):
474474

475475
def post_save(self, domain, created=False):
476476
if created:
477-
release = domain.app.release_set.latest()
478-
self.release = release.new(self.request.user)
479-
domain.app.deploy(self.release)
480-
481-
def destroy(self, request, **kwargs):
482-
domain = self.model.objects.get(domain=self.kwargs['id'])
483-
domain.delete()
484-
release = domain.app.release_set.latest()
485-
self.release = release.new(self.request.user)
486-
domain.app.deploy(self.release)
487-
return Response(status=status.HTTP_204_NO_CONTENT)
477+
domain.create()
488478

489479
def get_queryset(self, **kwargs):
490480
app = get_object_or_404(models.App, id=self.kwargs['id'])

0 commit comments

Comments
 (0)