fix(app): only set initial structure when build hook is triggered

As part of the effort to move code from views into models,
we would always scale an app to an initial structure on every deploy.
This made it impossible to, for example, set a BUILDPACK_URL without
triggering a false deploy and timeout.

Moving the logic back into the BuildView where it belongs.

Author: Gabriel Monroy

controller/api/models.py

@@ -129,11 +129,6 @@ def delete(self, *args, **kwargs):
 
     def deploy(self, release):
         tasks.deploy_release.delay(self, release).get()
-        if self.structure == {}:
-            # scale the web process by 1 initially
-            self.structure = {'web': 1}
-            self.save()
-            self.scale()
 
     def destroy(self, *args, **kwargs):
         return self.delete(*args, **kwargs)

controller/api/views.py

@@ -344,6 +344,10 @@ def post_save(self, build, created=False):
         if created:
             release = build.app.release_set.latest()
             self.release = release.new(self.request.user, build=build)
+            # scale the web process by 1 initially
+            if build.app.structure == {}:
+                build.app.structure = {'web': 1}
+                build.app.save()
             build.app.deploy(self.release)
 
     def get_success_headers(self, data):