Skip to content

Commit 958ad28

Browse files
committed
Merge pull request #3591 from aledbf/update-nginx-1.9
feat(router): nginx 1.9.0. Remove third party tcp module
2 parents 3182d1c + 5048c62 commit 958ad28

3 files changed

Lines changed: 6 additions & 20 deletions

File tree

docs/customizing_deis/router_settings.rst

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,7 @@ setting description
4141
/deis/router/bodySize nginx body size setting (default: 1m)
4242
/deis/router/defaultTimeout default timeout value in seconds. Should be greater then the frontfacing load balancers timeout value (default: 1300)
4343
/deis/router/builder/timeout/connect proxy_connect_timeout for deis-builder (default: 10000). Unit in miliseconds
44-
/deis/router/builder/timeout/read proxy_read_timeout for deis-builder (default: 1200000). Unit in miliseconds
45-
/deis/router/builder/timeout/send proxy_send_timeout for deis-builder (default: 1200000). Unit in miliseconds
46-
/deis/router/builder/timeout/tcp timeout for deis-builder (default: 1200000). Unit in miliseconds
44+
/deis/router/builder/timeout/tcp proxy_timeout for deis-builder (default: 1200000). Unit in miliseconds
4745
/deis/router/controller/timeout/connect proxy_connect_timeout for deis-controller (default: 10m)
4846
/deis/router/controller/timeout/read proxy_read_timeout for deis-controller (default: 20m)
4947
/deis/router/controller/timeout/send proxy_send_timeout for deis-controller (default: 20m)

router/build.sh

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ if [[ -z $DOCKER_BUILD ]]; then
1010
exit 1
1111
fi
1212

13-
export VERSION_NGINX=nginx-1.8.0
14-
export VERSION_TCP_PROXY=f2156eff9f6621aaf601eaa8dee40c6820dea0b0
13+
export VERSION_NGINX=nginx-1.9.0
1514
export VERSION_NAXSI=0d53a64ed856e694fcb4038748c8cf6d5551a603
1615

1716
export BUILD_PATH=/tmp/build
@@ -32,19 +31,15 @@ apt-get update \
3231

3332
# grab the source files
3433
curl -sSL http://nginx.org/download/$VERSION_NGINX.tar.gz -o $BUILD_PATH/$VERSION_NGINX.tar.gz
35-
curl -sSL https://github.com/yaoweibin/nginx_tcp_proxy_module/archive/$VERSION_TCP_PROXY.tar.gz -o $BUILD_PATH/$VERSION_TCP_PROXY.tar.gz
3634
curl -sSL https://github.com/nbs-system/naxsi/archive/$VERSION_NAXSI.tar.gz -o $BUILD_PATH/$VERSION_NAXSI.tar.gz
3735

3836
# expand the source files
3937
tar xzf $VERSION_NGINX.tar.gz
40-
tar xzf $VERSION_TCP_PROXY.tar.gz
4138
tar xzf $VERSION_NAXSI.tar.gz
4239

4340
# build nginx
4441
cd $BUILD_PATH/$VERSION_NGINX
4542

46-
patch -p1 < $BUILD_PATH/nginx_tcp_proxy_module-$VERSION_TCP_PROXY/tcp.patch
47-
4843
./configure \
4944
--prefix=$PREFIX \
5045
--pid-path=/run/nginx.pid \
@@ -63,7 +58,7 @@ patch -p1 < $BUILD_PATH/nginx_tcp_proxy_module-$VERSION_TCP_PROXY/tcp.patch
6358
--with-http_sub_module \
6459
--with-mail \
6560
--with-mail_ssl_module \
66-
--add-module=$BUILD_PATH/nginx_tcp_proxy_module-$VERSION_TCP_PROXY \
61+
--with-stream \
6762
--add-module=$BUILD_PATH/naxsi-$VERSION_NAXSI/naxsi_src \
6863
&& make && make install
6964

router/image/templates/nginx.conf

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -292,22 +292,15 @@ http {
292292

293293
## start builder
294294
{{ if .deis_builder_host }}
295-
tcp {
296-
access_log /opt/nginx/logs/git.log;
297-
tcp_nodelay on;
298-
timeout {{ or (.deis_router_builder_timeout_tcp) "1200000" }};
299-
300-
# same directive names, but these are in miliseconds...
301-
proxy_connect_timeout {{ or (.deis_router_builder_timeout_connect) "10000" }};
302-
proxy_send_timeout {{ or (.deis_router_builder_timeout_send) "1200000" }};
303-
proxy_read_timeout {{ or (.deis_router_builder_timeout_read) "1200000" }};
304-
295+
stream {
305296
upstream builder {
306297
server {{ .deis_builder_host }}:{{ .deis_builder_port }};
307298
}
308299

309300
server {
310301
listen 2222;
302+
proxy_connect_timeout {{ or (.deis_router_builder_timeout_connect) "10000" }};
303+
proxy_timeout {{ or (.deis_router_builder_timeout_tcp) "1200000" }};
311304
proxy_pass builder;
312305
}
313306
}{{ end }}

0 commit comments

Comments
 (0)