Skip to content

Commit 8f48f64

Browse files
author
Matthew Fisher
committed
docs(contrib): maintainers merge their own PRs
if the PR submitter is a maintainer, he or she merges it themself (after 2 LGTMs). This is intended for commit stream cleanliness and to allow them to fix their own PR before merging it.
1 parent a1ce3cd commit 8f48f64

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

docs/contributing/standards.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,10 @@ Deis maintainers add "**LGTM**" (Looks Good To Me) in code
114114
review comments to indicate that a PR is acceptable. Any code change--other than
115115
a simple typo fix or one-line documentation change--requires at least two of
116116
Deis' maintainers to accept the change in this manner before it can be merged.
117+
If the PR is from a Deis maintainer, then he or she should be the one to merge
118+
it. This is for cleanliness in the commit stream as well as giving the
119+
maintainer the benefit of adding more fixes or commits to a PR before the
120+
merge.
117121

118122
.. _Python: http://www.python.org/
119123
.. _Go: http://golang.org/

0 commit comments

Comments
 (0)