Skip to content

Commit 8ef3d5b

Browse files
committed
Merge pull request #1291 from deis/readable_data_containers
fix(Makefile): only install data containers if they don't exist
2 parents a12c6eb + 46bca09 commit 8ef3d5b

1 file changed

Lines changed: 15 additions & 11 deletions

File tree

Makefile

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -40,23 +40,27 @@ clean: uninstall
4040
full-clean: clean
4141
$(call ssh_all,'for c in $(ALL_COMPONENTS); do docker rmi deis-$$c; done')
4242

43-
install: check-fleet install-routers
43+
install: check-fleet install-routers install-data-containers
4444
$(FLEETCTL) load $(START_UNITS)
4545
$(FLEETCTL) load controller/systemd/*.service
4646
$(FLEETCTL) load builder/systemd/*.service
47-
echo $(shell make install-data-containers)
4847

4948
install-data-containers: check-fleet
5049
@$(foreach T, $(DATA_CONTAINER_TEMPLATES), \
51-
cp $(T).template . ; \
52-
NEW_FILENAME=`ls *.template | sed 's/\.template//g'`; \
53-
mv *.template $$NEW_FILENAME ; \
54-
MACHINE_ID=`$(FLEETCTL) list-machines --no-legend --full list-machines | awk 'BEGIN { OFS="\t"; srand() } { print rand(), $$1 }' | sort -n | cut -f2- | head -1` ; \
55-
sed -e "s/CHANGEME/$$MACHINE_ID/" $$NEW_FILENAME > $$NEW_FILENAME.bak ; \
56-
rm -f $$NEW_FILENAME ; \
57-
mv $$NEW_FILENAME.bak $$NEW_FILENAME ; \
58-
$(FLEETCTL) load $$NEW_FILENAME ; \
59-
rm -f $$NEW_FILENAME ; \
50+
UNIT=`basename $(T)` ; \
51+
if [[ `$(FLEETCTL) list-units | grep $$UNIT` ]]; then \
52+
echo $$UNIT already loaded. Skipping... ; \
53+
else \
54+
cp $(T).template . ; \
55+
NEW_FILENAME=`ls *.template | sed 's/\.template//g'`; \
56+
mv *.template $$NEW_FILENAME ; \
57+
MACHINE_ID=`$(FLEETCTL) list-machines --no-legend --full list-machines | awk 'BEGIN { OFS="\t"; srand() } { print rand(), $$1 }' | sort -n | cut -f2- | head -1` ; \
58+
sed -e "s/CHANGEME/$$MACHINE_ID/" $$NEW_FILENAME > $$NEW_FILENAME.bak ; \
59+
rm -f $$NEW_FILENAME ; \
60+
mv $$NEW_FILENAME.bak $$NEW_FILENAME ; \
61+
$(FLEETCTL) load $$NEW_FILENAME ; \
62+
rm -f $$NEW_FILENAME ; \
63+
fi ; \
6064
)
6165

6266
install-routers: check-fleet

0 commit comments

Comments
 (0)