Skip to content

Commit 8c82a92

Browse files
committed
fix(models): catch proper kube exceptions in certficates so secrets get created
Fixes #444
1 parent ee4d328 commit 8c82a92

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

rootfs/api/models/certificate.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
from api.models import AuditedModel, validate_label, AlreadyExists
1515
from api.models.domain import Domain
1616

17+
from scheduler import KubeHTTPException
1718

1819
import logging
1920
logger = logging.getLogger(__name__)
@@ -174,7 +175,7 @@ def attach(self, *args, **kwargs):
174175
try:
175176
# We raise an exception when a secret doesn't exist
176177
self._scheduler._get_secret(app, name)
177-
except RuntimeError:
178+
except KubeHTTPException:
178179
self._scheduler._create_secret(app, name, data)
179180

180181
# get config for the service
@@ -206,7 +207,7 @@ def detach(self, *args, **kwargs):
206207
# We raise an exception when a secret doesn't exist
207208
self._scheduler._get_secret(app, name)
208209
self._scheduler._delete_secret(app, name)
209-
except RuntimeError as e:
210+
except KubeHTTPException as e:
210211
logger.critical(e)
211212

212213
# get config for the service

0 commit comments

Comments
 (0)