Skip to content

Commit 82b6368

Browse files
aboyettJoshua-Anderson
authored andcommitted
fix(settings): remove duplicated 'v' in user agent (#188)
the workflow-cli version is defined based on the git tag which already has a prepended v (v2.4.0) resulting in the user agent seen below "GET /v2/apps/foo/pods/?limit=100 HTTP/1.1" 200 593 "Deis Client vv2.4.0" Fixes #186
1 parent 78118eb commit 82b6368

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

settings/settings.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616
const DefaultResponseLimit = 100
1717

1818
// UserAgent is the user agent used by the CLI
19-
var UserAgent = "Deis Client v" + version.Version
19+
var UserAgent = "Deis Client " + version.Version
2020

2121
type settingsFile struct {
2222
Username string `json:"username"`

settings/settings_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ func TestLoadSave(t *testing.T) {
6868
expected: s.Limit,
6969
},
7070
{
71-
key: "Deis Client v" + version.Version,
71+
key: "Deis Client " + version.Version,
7272
expected: s.Client.UserAgent,
7373
},
7474
}
@@ -123,7 +123,7 @@ func TestLoadSave(t *testing.T) {
123123
expected: s.Limit,
124124
},
125125
{
126-
key: "Deis Client v" + version.Version,
126+
key: "Deis Client " + version.Version,
127127
expected: s.Client.UserAgent,
128128
},
129129
}

0 commit comments

Comments
 (0)