check for no creds on layer:scale, with tests

Author: Gabriel Monroy

api/models.py

@@ -115,7 +115,7 @@ class Provider(UuidAuditedModel):
     owner = models.ForeignKey(settings.AUTH_USER_MODEL)
     id = models.SlugField(max_length=64)
     type = models.SlugField(max_length=16, choices=PROVIDERS)
-    creds = fields.CredentialsField()
+    creds = fields.CredentialsField(blank=True)
 
     class Meta:
         unique_together = (('owner', 'id'),)

api/tests/layer.py

@@ -158,3 +158,23 @@ def test_layer_scale(self):
         response = self.client.get(url)
         self.assertEqual(response.status_code, 200)
         self.assertEqual(response.data['layers'], json.dumps(body))
+
+    def test_layer_scale_no_creds(self):
+        url = '/api/providers/autotest'
+        body = {'creds': json.dumps({}) }
+        response = self.client.patch(url, json.dumps(body), content_type='application/json')
+        self.assertEqual(response.status_code, 200)
+        # try to scale and a formation
+        url = '/api/formations'
+        body = {'id': 'autotest'}
+        response = self.client.post(url, json.dumps(body), content_type='application/json')
+        self.assertEqual(response.status_code, 201)
+        formation_id = response.data['id']  # noqa
+        url = '/api/formations/{formation_id}/layers'.format(**locals())
+        body = {'id': 'runtime', 'flavor': 'autotest', 'run_list': 'recipe[deis::runtime]'}
+        response = self.client.post(url, json.dumps(body), content_type='application/json')
+        self.assertEqual(response.status_code, 201)
+        url = '/api/formations/{formation_id}/scale/layers'.format(**locals())
+        body = {'runtime': 1}
+        response = self.client.post(url, json.dumps(body), content_type='application/json')
+        self.assertEqual(response.status_code, 400)

api/views.py

@@ -174,6 +174,12 @@ def scale_layers(self, request, **kwargs):
                 new_structure[target] = int(count)
         except ValueError:
             return Response('Invalid scaling format', status=HTTP_400_BAD_REQUEST)
+        # check for empty credentials
+        for p in models.Provider.objects.filter(owner=request.user):
+            if p.creds:
+                break
+        else:
+            return Response('No provider credentials available', status=HTTP_400_BAD_REQUEST)
         formation = self.get_object()
         formation.layers.update(new_structure)
         try: