Merge pull request #149 from sgoings/shortcuts-test

feat(shortcuts): add shortcuts test

Author: Seth Goings

cmd/config.go

@@ -92,7 +92,7 @@ func ConfigSet(appID string, configVars []string) error {
 
 	// NOTE(bacongobbler): check if the user is using the old way to set healthchecks. If so,
 	// send them a deprecation notice.
-	for key, _ := range configMap {
+	for key := range configMap {
 		if strings.Contains(key, "HEALTHCHECK_") {
 			fmt.Println(`Hey there! We've noticed that you're using 'deis config:set HEALTHCHECK_URL'
 to set up healthchecks. This functionality has been deprecated. In the future, please use

cmd/registry.go

@@ -124,7 +124,7 @@ Examples: username=bob password=s3cur3pw1`, item)
 	}
 
 	if parts[0] != "username" && parts[0] != "password" {
-		return "", "", fmt.Errorf(`%s is invalid. Valid keys are "username" or "password".`, parts[0])
+		return "", "", fmt.Errorf(`%s is invalid. Valid keys are "username" or "password"`, parts[0])
 	}
 
 	return parts[0], parts[1], nil

cmd/shortcuts.go

@@ -7,10 +7,16 @@ import (
 	"github.com/deis/workflow-cli/cli"
 )
 
-// Shortcuts displays all relevant shortcuts for the CLI.
+// ShortcutsList displays all relevant shortcuts for the CLI.
 func ShortcutsList() error {
+	fmt.Println(sortShortcuts())
+
+	return nil
+}
+
+func sortShortcuts() string {
 	var (
-		strBuilder string = ""
+		strBuilder string
 		keys       []string
 	)
 
@@ -25,7 +31,5 @@ func ShortcutsList() error {
 		strBuilder += fmt.Sprintf("%s -> %s\n", k, cli.Shortcuts[k])
 	}
 
-	fmt.Println(strBuilder)
-
-	return nil
+	return strBuilder
 }

cmd/shortcuts_test.go

@@ -0,0 +1,35 @@
+package cmd
+
+import (
+  "testing"
+)
+
+
+func TestShortcutsList(t *testing.T) {
+	t.Parallel()
+
+  expected := `create -> apps:create
+destroy -> apps:destroy
+info -> apps:info
+login -> auth:login
+logout -> auth:logout
+logs -> apps:logs
+open -> apps:open
+passwd -> auth:passwd
+pull -> builds:create
+register -> auth:register
+rollback -> releases:rollback
+run -> apps:run
+scale -> ps:scale
+sharing -> perms:list
+sharing:add -> perms:create
+sharing:list -> perms:list
+sharing:remove -> perms:delete
+whoami -> auth:whoami
+`
+  actual := sortShortcuts()
+  if actual != expected {
+    t.Errorf("Expected %s, Got %s", expected, actual)
+  }
+
+}