Merge pull request #4202 from Joshua-Anderson/tests-look-for-warning

fix(tests): abort if warning is found in output

Author: carmstrong

tests/utils/itutils.go

@@ -295,11 +295,16 @@ func Execute(t *testing.T, cmd string, params interface{}, failFlag bool, expect
 			}
 		}
 	case false:
-		if _, _, err := RunCommandWithStdoutStderr(cmdl); err != nil {
+		stdout, stderr, err := RunCommandWithStdoutStderr(cmdl)
+		if err != nil {
 			t.Fatal(err)
-		} else {
-			fmt.Println("ok")
 		}
+
+		if containsWarning(stdout.String()) || containsWarning(stderr.String()) {
+			t.Fatal("Warning found in output, aborting")
+		}
+
+		fmt.Println("ok")
 	}
 }
 
@@ -339,3 +344,11 @@ func GetRandomApp() string {
 	}
 	return apps[rand.Intn(len(apps))]
 }
+
+func containsWarning(out string) bool {
+	if strings.Contains(out, "WARNING") {
+		return true
+	}
+
+	return false
+}