Merge pull request #3598 from ngpestelos/non-existing-app-status

fix(router): return 404 for non-existing app

Author: Matthew Fisher

router/image/templates/nginx.conf

@@ -302,6 +302,10 @@ http {
         }
         location /router-nginx-status {
             stub_status on;
+            return 200;
+        }
+        location / {
+            return 404;
         }
     }
 }

tests/apps_test.go

@@ -3,6 +3,7 @@
 package tests
 
 import (
+	"fmt"
 	"math/rand"
 	"os"
 	"testing"
@@ -108,6 +109,7 @@ func appsLogsTest(t *testing.T, params *utils.DeisTestConfig) {
 
 func appsOpenTest(t *testing.T, params *utils.DeisTestConfig) {
 	utils.CurlApp(t, *params)
+	utils.CurlWithFail(t, fmt.Sprintf("http://%s.%s", "this-app-does-not-exist", params.Domain), true, "404 Not Found")
 }
 
 func appsRunTest(t *testing.T, params *utils.DeisTestConfig) {