feat(logger): expose logRoot as a flag

Author: Matthew Fisher

logger/main.go

@@ -28,6 +28,7 @@ var (
 func init() {
 	flag.StringVar(&logAddr, "log-addr", "0.0.0.0", "bind address for the logger")
 	flag.IntVar(&logPort, "log-port", 514, "bind port for the logger")
+	flag.StringVar(&syslogd.LogRoot, "log-root", "/data/logs", "log path to store logs")
 	flag.BoolVar(&enablePublish, "publish", false, "enable publishing to service discovery")
 	flag.StringVar(&publishHost, "publish-host", getopt("HOST", "127.0.0.1"), "service discovery hostname")
 	flag.IntVar(&publishInterval, "publish-interval", 10, "publish interval in seconds")

logger/syslogd/syslogd.go

@@ -13,7 +13,7 @@ import (
 	"github.com/deis/deis/logger/drain"
 )
 
-const logRoot = "/data/logs"
+var LogRoot string
 
 type handler struct {
 	// To simplify implementation of our handler we embed helper
@@ -51,7 +51,7 @@ func getLogFile(message string) (io.Writer, error) {
 		return nil, fmt.Errorf("Could not find app name in message: %s", message)
 	}
 	appName := match[1]
-	filePath := path.Join(logRoot, appName+".log")
+	filePath := path.Join(LogRoot, appName+".log")
 	// check if file exists
 	exists, err := fileExists(filePath)
 	if err != nil {
@@ -99,11 +99,11 @@ func (h *handler) mainLoop() {
 // Listen starts a new syslog server which runs until it receives a signal.
 func Listen(signalChan chan os.Signal, cleanupDone chan bool, bindAddr string) {
 	fmt.Println("Starting syslog...")
-	// If logRoot doesn't exist, create it
+	// If LogRoot doesn't exist, create it
 	// equivalent to Python's `if not os.path.exists(filename)`
-	if _, err := os.Stat(logRoot); os.IsNotExist(err) {
-		if err = os.MkdirAll(logRoot, 0777); err != nil {
-			log.Fatalf("unable to create logRoot at %s", logRoot)
+	if _, err := os.Stat(LogRoot); os.IsNotExist(err) {
+		if err = os.MkdirAll(LogRoot, 0777); err != nil {
+			log.Fatalf("unable to create LogRoot at %s: %v", LogRoot, err)
 		}
 	}
 	// Create a server with one handler and run one listen gorutine