chore(buildpack): remove BUILDPACK_URL env when creating app

Author: duanhongyi

cmd/apps.go

@@ -7,9 +7,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/drycc/controller-sdk-go/api"
 	"github.com/drycc/controller-sdk-go/apps"
-	"github.com/drycc/controller-sdk-go/config"
 	"github.com/drycc/controller-sdk-go/domains"
 	"github.com/drycc/workflow-cli/pkg/git"
 	"github.com/drycc/workflow-cli/pkg/logging"
@@ -18,7 +16,7 @@ import (
 )
 
 // AppCreate creates an app.
-func (d *DryccCmd) AppCreate(id, buildpack, remote string, noRemote bool) error {
+func (d *DryccCmd) AppCreate(id, remote string, noRemote bool) error {
 	s, err := settings.Load(d.ConfigFile)
 	if err != nil {
 		return err
@@ -37,17 +35,6 @@ func (d *DryccCmd) AppCreate(id, buildpack, remote string, noRemote bool) error
 
 	d.Printf("done, created %s\n", app.ID)
 
-	if buildpack != "" {
-		configValues := api.Config{
-			Values: map[string]interface{}{
-				"BUILDPACK_URL": buildpack,
-			},
-		}
-		if _, err = config.Set(s.Client, app.ID, configValues); d.checkAPICompatibility(s.Client, err) != nil {
-			return err
-		}
-	}
-
 	if !noRemote {
 		if err = git.CreateRemote(git.DefaultCmd, s.Client.ControllerURL.Host, remote, app.ID); err != nil {
 			if strings.Contains(err.Error(), fmt.Sprintf("fatal: remote %s already exists.", remote)) {

cmd/apps_test.go

@@ -332,7 +332,7 @@ func TestRemoteExists(t *testing.T) {
 	var b bytes.Buffer
 	cmdr := DryccCmd{WOut: &b, ConfigFile: cf}
 
-	err = cmdr.AppCreate("foo", "", "drycc", false)
+	err = cmdr.AppCreate("foo", "drycc", false)
 
 	assert.Equal(t, err.Error(), `A git remote with the name drycc already exists. To overwrite this remote run:
 drycc git:remote --force --remote drycc --app foo`,

cmd/cmd.go

@@ -10,7 +10,7 @@ import (
 
 // Commander is interface definition for running commands
 type Commander interface {
-	AppCreate(string, string, string, bool) error
+	AppCreate(string, string, bool) error
 	AppsList(int) error
 	AppInfo(string) error
 	AppOpen(string) error

parser/apps.go

@@ -73,8 +73,6 @@ Arguments:
 Options:
   --no-remote
     do not create a 'drycc' git remote.
-  -b --buildpack BUILDPACK
-    a buildpack url to use for this app
   -r --remote REMOTE
     name of remote to create. [default: drycc]
 `
@@ -86,11 +84,10 @@ Options:
 	}
 
 	id := safeGetValue(args, "<id>")
-	buildpack := safeGetValue(args, "--buildpack")
 	remote := safeGetValue(args, "--remote")
 	noRemote := args["--no-remote"].(bool)
 
-	return cmdr.AppCreate(id, buildpack, remote, noRemote)
+	return cmdr.AppCreate(id, remote, noRemote)
 }
 
 func appsList(argv []string, cmdr cmd.Commander) error {

parser/apps_test.go

@@ -12,7 +12,7 @@ import (
 // Create fake implementations of each method that return the argument
 // we expect to have called the function (as an error to satisfy the interface).
 
-func (d FakeDryccCmd) AppCreate(string, string, string, bool) error {
+func (d FakeDryccCmd) AppCreate(string, string, bool) error {
 	return errors.New("apps:create")
 }