Skip to content

Commit 5d0deae

Browse files
committed
Fixed #449 -- deis releases:info honors specified version.
1 parent 1c167b9 commit 5d0deae

2 files changed

Lines changed: 12 additions & 0 deletions

File tree

api/tests/test_release.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,14 @@ def test_release(self):
120120
self.assertIn('PATH', config3_values)
121121
self.assertEqual(
122122
config3_values['PATH'], 'bin:/usr/local/bin:/usr/bin:/bin')
123+
# check that we can fetch a previous release
124+
url = '/api/apps/{app_id}/releases/2'.format(**locals())
125+
response = self.client.get(url)
126+
self.assertEqual(response.status_code, 200)
127+
release2 = response.data
128+
self.assertNotEqual(release2['uuid'], release3['uuid'])
129+
self.assertNotEqual(release2['build'], release3['build'])
130+
self.assertEquals(release2['version'], 2)
123131
# disallow post/put/patch/delete
124132
url = '/api/apps/{app_id}/releases'.format(**locals())
125133
self.assertEqual(self.client.post(url).status_code, 405)

api/views.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,10 @@ class AppReleaseViewSet(BaseAppViewSet):
587587
model = models.Release
588588
serializer_class = serializers.ReleaseSerializer
589589

590+
def get_object(self, *args, **kwargs):
591+
"""Get Release by version always."""
592+
return self.get_queryset(**kwargs).get(version=self.kwargs['version'])
593+
590594

591595
class AppContainerViewSet(OwnerViewSet):
592596
"""RESTful views for :class:`~api.models.Container`."""

0 commit comments

Comments
 (0)