Skip to content

Commit 5ca102d

Browse files
committed
Merge pull request #117 from mboersma/fix-exception-handlers
fix(api): delete new_release only if it exists
2 parents e31dc71 + 16699dd commit 5ca102d

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

rootfs/api/models.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -738,7 +738,8 @@ def create(self, user, *args, **kwargs):
738738
self.app.deploy(user, new_release)
739739
return new_release
740740
except RuntimeError:
741-
new_release.delete()
741+
if 'new_release' in locals():
742+
new_release.delete()
742743
raise
743744

744745
def save(self, **kwargs):
@@ -895,7 +896,8 @@ def rollback(self, user, version):
895896
self.app.deploy(user, new_release)
896897
return new_release
897898
except RuntimeError:
898-
new_release.delete()
899+
if 'new_release' in locals():
900+
new_release.delete()
899901
raise
900902

901903
def save(self, *args, **kwargs): # noqa

rootfs/api/views.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,8 @@ def rollback(self, request, **kwargs):
363363
except EnvironmentError as e:
364364
return Response({'detail': str(e)}, status=status.HTTP_400_BAD_REQUEST)
365365
except RuntimeError:
366-
new_release.delete()
366+
if 'new_release' in locals():
367+
new_release.delete()
367368
raise
368369

369370

0 commit comments

Comments
 (0)