Skip to content

Commit 575907e

Browse files
author
Seth Goings
committed
fix(Makefile/travis): use standard vars
1 parent acd46da commit 575907e

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
DEIS_REGISTRY ?= $(DEV_REGISTRY)/
33
IMAGE_PREFIX ?= deis
44
COMPONENT ?= workflow
5-
BUILD_TAG ?= git-$(shell git rev-parse --short HEAD)
6-
IMAGE = $(DEIS_REGISTRY)$(IMAGE_PREFIX)/$(COMPONENT):$(BUILD_TAG)
5+
VERSION ?= git-$(shell git rev-parse --short HEAD)
6+
IMAGE = $(DEIS_REGISTRY)$(IMAGE_PREFIX)/$(COMPONENT):$(VERSION)
77
SHELL_SCRIPTS = $(wildcard rootfs/bin/*) $(shell find "rootfs" -name '*.sh') $(wildcard _scripts/*.sh)
88

99
info:
10-
@echo "Build tag: ${BUILD_TAG}"
10+
@echo "Build tag: ${VERSION}"
1111
@echo "Registry: ${DEIS_REGISTRY}"
1212
@echo "Image: ${IMAGE}"
1313

@@ -20,10 +20,10 @@ check-docker:
2020
prep-bintray-json:
2121
# TRAVIS_TAG is set to the tag name if the build is a tag
2222
ifdef TRAVIS_TAG
23-
@jq '.version.name |= "$(BUILD_TAG)"' _scripts/ci/bintray-template.json | \
23+
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json | \
2424
jq '.package.repo |= "deis"' > _scripts/ci/bintray-ci.json
2525
else
26-
@jq '.version.name |= "$(BUILD_TAG)"' _scripts/ci/bintray-template.json \
26+
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json \
2727
> _scripts/ci/bintray-ci.json
2828
endif
2929

_scripts/deploy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
cd "$(dirname "$0")" || exit 1
77

8-
export IMAGE_PREFIX=deisci BUILD_TAG=v2-alpha
8+
export IMAGE_PREFIX=deisci VERSION=v2-alpha
99
docker login -e="$DOCKER_EMAIL" -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"
1010
DEIS_REGISTRY='' make -C .. docker-build docker-push
1111
docker login -e="$QUAY_EMAIL" -u="$QUAY_USERNAME" -p="$QUAY_PASSWORD" quay.io

0 commit comments

Comments
 (0)