Skip to content

Commit 52255dc

Browse files
committed
Merge pull request #1845 from carmstrong/remove_deprecated_condition
chore(*/systemd): remove deprecated X-Condition in fleet units
2 parents 067e5d4 + 050fb06 commit 52255dc

11 files changed

Lines changed: 13 additions & 13 deletions

File tree

builder/systemd/deis-builder-data.service.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ ExecStart=/bin/sh -c "docker inspect deis-builder-data >/dev/null 2>&1 || docker
1010
WantedBy=multi-user.target
1111

1212
[X-Fleet]
13-
X-ConditionMachineID=CHANGEME
13+
MachineID=CHANGEME

builder/systemd/deis-builder.service

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ ExecStopPost=/usr/bin/docker stop deis-builder
1616
WantedBy=multi-user.target
1717

1818
[X-Fleet]
19-
X-ConditionMachineOf=deis-builder-data.service
19+
MachineOf=deis-builder-data.service

controller/scheduler/coreos.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ def _create_container(self, name, image, command, unit, **kwargs):
135135
tags = kwargs.get('tags', {})
136136
if tags:
137137
tagset = ' '.join(['"{}={}"'.format(k, v) for k, v in tags.items()])
138-
unit.append({"section": "X-Fleet", "name": "X-ConditionMachineMetadata",
138+
unit.append({"section": "X-Fleet", "name": "MachineMetadata",
139139
"value": tagset})
140140
# post unit to fleet
141141
self._put_unit(name, {"desiredState": "launched", "options": unit})
@@ -325,7 +325,7 @@ def attach(self, name):
325325
{"section": "Service", "name": "ExecStartPre", "value": '''/bin/sh -c "until docker inspect {name} >/dev/null 2>&1; do sleep 1; done"'''}, # noqa
326326
{"section": "Service", "name": "ExecStart", "value": '''/bin/sh -c "docker logs -f {name} 2>&1 | logger -p local0.info -t {app}[{c_type}.{c_num}] --udp --server $(etcdctl get /deis/logs/host) --port $(etcdctl get /deis/logs/port)"'''}, # noqa
327327
{"section": "Service", "name": "TimeoutStartSec", "value": "20m"},
328-
{"section": "X-Fleet", "name": "X-ConditionMachineOf", "value": "{name}.service"},
328+
{"section": "X-Fleet", "name": "MachineOf", "value": "{name}.service"},
329329
]
330330

331331

@@ -337,7 +337,7 @@ def attach(self, name):
337337
{"section": "Service", "name": "ExecStart", "value": '''/bin/sh -c "port=$(docker inspect -f '{{{{range $i, $e := .NetworkSettings.Ports }}}}{{{{$p := index $e 0}}}}{{{{$p.HostPort}}}}{{{{end}}}}' {name}); echo Connected to $COREOS_PRIVATE_IPV4:$port/tcp, publishing to etcd...; while netstat -lnt | grep :$port >/dev/null; do etcdctl set /deis/services/{app}/{name} $COREOS_PRIVATE_IPV4:$port --ttl 60 >/dev/null; sleep 45; done"'''}, # noqa
338338
{"section": "Service", "name": "ExecStop", "value": "/usr/bin/etcdctl rm --recursive /deis/services/{app}/{name}"}, # noqa
339339
{"section": "Service", "name": "TimeoutStartSec", "value": "20m"},
340-
{"section": "X-Fleet", "name": "X-ConditionMachineOf", "value": "{name}.service"},
340+
{"section": "X-Fleet", "name": "MachineOf", "value": "{name}.service"},
341341
]
342342

343343

controller/systemd/deis-controller.service

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ ExecStopPost=/usr/bin/docker stop deis-controller
1515
WantedBy=multi-user.target
1616

1717
[X-Fleet]
18-
X-ConditionMachineOf=deis-logger.service
18+
MachineOf=deis-logger.service

database/systemd/deis-database-data.service.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ ExecStart=/bin/sh -c "docker inspect deis-database-data >/dev/null 2>&1 || docke
1010
WantedBy=multi-user.target
1111

1212
[X-Fleet]
13-
X-ConditionMachineID=CHANGEME
13+
MachineID=CHANGEME

database/systemd/deis-database.service

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ ExecStopPost=/usr/bin/docker stop deis-database
1616
WantedBy=multi-user.target
1717

1818
[X-Fleet]
19-
X-ConditionMachineOf=deis-database-data.service
19+
MachineOf=deis-database-data.service

logger/systemd/deis-logger-data.service.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ ExecStart=/bin/sh -c "docker inspect deis-logger-data >/dev/null 2>&1 || docker
1010
WantedBy=multi-user.target
1111

1212
[X-Fleet]
13-
X-ConditionMachineID=CHANGEME
13+
MachineID=CHANGEME

logger/systemd/deis-logger.service

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,4 @@ ExecStopPost=/usr/bin/docker stop deis-logger
1515
WantedBy=multi-user.target
1616

1717
[X-Fleet]
18-
X-ConditionMachineOf=deis-logger-data.service
18+
MachineOf=deis-logger-data.service

registry/systemd/deis-registry-data.service.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ ExecStart=/bin/sh -c "docker inspect deis-registry-data >/dev/null 2>&1 || docke
1010
WantedBy=multi-user.target
1111

1212
[X-Fleet]
13-
X-ConditionMachineID=CHANGEME
13+
MachineID=CHANGEME

registry/systemd/deis-registry.service

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ ExecStopPost=/usr/bin/docker stop deis-registry
1616
WantedBy=multi-user.target
1717

1818
[X-Fleet]
19-
X-ConditionMachineOf=deis-registry-data.service
19+
MachineOf=deis-registry-data.service

0 commit comments

Comments
 (0)