Skip to content

Commit 4f59717

Browse files
mboersmamboersma
committed
Merge pull request #2256 from mboersma/remove-eclipsisms
style(client): remove PyDev code-linting comments
2 parents be1047a + 7750588 commit 4f59717

1 file changed

Lines changed: 33 additions & 33 deletions

File tree

‎client/deis.py‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ def apps_create(self, args):
446446
finally:
447447
progress.cancel()
448448
progress.join()
449-
if response.status_code == requests.codes.created: # @UndefinedVariable
449+
if response.status_code == requests.codes.created:
450450
data = response.json()
451451
app_id = data['id']
452452
self._logger.info("done, created {}".format(app_id))
@@ -510,8 +510,8 @@ def apps_destroy(self, args):
510510
finally:
511511
progress.cancel()
512512
progress.join()
513-
if response.status_code in (requests.codes.no_content, # @UndefinedVariable
514-
requests.codes.not_found): # @UndefinedVariable
513+
if response.status_code in (requests.codes.no_content,
514+
requests.codes.not_found):
515515
self._logger.info('done in {}s'.format(int(time.time() - before)))
516516
try:
517517
# If the requested app is a heroku app, delete the git remote
@@ -532,7 +532,7 @@ def apps_list(self, args):
532532
Usage: deis apps:list
533533
"""
534534
response = self._dispatch('get', '/v1/apps')
535-
if response.status_code == requests.codes.ok: # @UndefinedVariable
535+
if response.status_code == requests.codes.ok:
536536
data = response.json()
537537
self._logger.info('=== Apps')
538538
for item in data['results']:
@@ -554,7 +554,7 @@ def apps_info(self, args):
554554
if not app:
555555
app = self._session.app
556556
response = self._dispatch('get', "/v1/apps/{}".format(app))
557-
if response.status_code == requests.codes.ok: # @UndefinedVariable
557+
if response.status_code == requests.codes.ok:
558558
self._logger.info("=== {} Application".format(app))
559559
self._logger.info(json.dumps(response.json(), indent=2) + '\n')
560560
self.ps_list(args)
@@ -578,7 +578,7 @@ def apps_open(self, args):
578578
app = self._session.app
579579
# TODO: replace with a single API call to apps endpoint
580580
response = self._dispatch('get', "/v1/apps/{}".format(app))
581-
if response.status_code == requests.codes.ok: # @UndefinedVariable
581+
if response.status_code == requests.codes.ok:
582582
url = response.json()['url']
583583
# use the OS's default handler to open this URL
584584
webbrowser.open('http://{}/'.format(url))
@@ -601,7 +601,7 @@ def apps_logs(self, args):
601601
app = self._session.app
602602
response = self._dispatch('get',
603603
"/v1/apps/{}/logs".format(app))
604-
if response.status_code == requests.codes.ok: # @UndefinedVariable
604+
if response.status_code == requests.codes.ok:
605605
# strip the last newline character
606606
for line in response.json().split('\n')[:-1]:
607607
# get the tag from the log
@@ -646,7 +646,7 @@ def apps_run(self, args):
646646
response = self._dispatch('post',
647647
"/v1/apps/{}/run".format(app),
648648
json.dumps(body))
649-
if response.status_code == requests.codes.ok: # @UndefinedVariable
649+
if response.status_code == requests.codes.ok:
650650
rc, output = json.loads(response.content)
651651
sys.stdout.write(output)
652652
sys.stdout.flush()
@@ -705,7 +705,7 @@ def auth_register(self, args):
705705
url = urlparse.urljoin(controller, '/v1/auth/register')
706706
payload = {'username': username, 'password': password, 'email': email}
707707
response = self._session.post(url, data=payload, allow_redirects=False)
708-
if response.status_code == requests.codes.created: # @UndefinedVariable
708+
if response.status_code == requests.codes.created:
709709
self._settings['controller'] = controller
710710
self._settings.save()
711711
self._logger.info("Registered {}".format(username))
@@ -771,7 +771,7 @@ def auth_login(self, args):
771771
payload = {'username': username, 'password': password}
772772
# post credentials to the login URL
773773
response = self._session.post(url, data=payload, allow_redirects=False)
774-
if response.status_code == requests.codes.ok: # @UndefinedVariable
774+
if response.status_code == requests.codes.ok:
775775
# retrieve and save the API token for future requests
776776
self._settings['controller'] = controller
777777
self._settings['username'] = username
@@ -849,7 +849,7 @@ def builds_create(self, args):
849849
finally:
850850
progress.cancel()
851851
progress.join()
852-
if response.status_code == requests.codes.created: # @UndefinedVariable
852+
if response.status_code == requests.codes.created:
853853
version = response.headers['x-deis-release']
854854
self._logger.info("done, v{}".format(version))
855855
else:
@@ -869,7 +869,7 @@ def builds_list(self, args):
869869
if not app:
870870
app = self._session.app
871871
response = self._dispatch('get', "/v1/apps/{}/builds".format(app))
872-
if response.status_code == requests.codes.ok: # @UndefinedVariable
872+
if response.status_code == requests.codes.ok:
873873
self._logger.info("=== {} Builds".format(app))
874874
data = response.json()
875875
for item in data['results']:
@@ -911,7 +911,7 @@ def config_list(self, args):
911911

912912
oneline = args.get('--oneline')
913913
response = self._dispatch('get', "/v1/apps/{}/config".format(app))
914-
if response.status_code == requests.codes.ok: # @UndefinedVariable
914+
if response.status_code == requests.codes.ok:
915915
config = response.json()
916916
values = config['values']
917917
self._logger.info("=== {} Config".format(app))
@@ -964,7 +964,7 @@ def config_set(self, args):
964964
finally:
965965
progress.cancel()
966966
progress.join()
967-
if response.status_code == requests.codes.created: # @UndefinedVariable
967+
if response.status_code == requests.codes.created:
968968
version = response.headers['x-deis-release']
969969
self._logger.info("done, v{}\n".format(version))
970970
config = response.json()
@@ -1010,7 +1010,7 @@ def config_unset(self, args):
10101010
finally:
10111011
progress.cancel()
10121012
progress.join()
1013-
if response.status_code == requests.codes.created: # @UndefinedVariable
1013+
if response.status_code == requests.codes.created:
10141014
version = response.headers['x-deis-release']
10151015
self._logger.info("done, v{}\n".format(version))
10161016
config = response.json()
@@ -1057,7 +1057,7 @@ def config_pull(self, args):
10571057
except IOError:
10581058
pass
10591059
response = self._dispatch('get', "/v1/apps/{}/config".format(app))
1060-
if response.status_code == requests.codes.ok: # @UndefinedVariable
1060+
if response.status_code == requests.codes.ok:
10611061
config = response.json()['values']
10621062
for k, v in config.items():
10631063
if interactive and raw_input("overwrite {} with {}? (y/N) ".format(k, v)) == 'y':
@@ -1119,7 +1119,7 @@ def domains_add(self, args):
11191119
finally:
11201120
progress.cancel()
11211121
progress.join()
1122-
if response.status_code == requests.codes.created: # @UndefinedVariable
1122+
if response.status_code == requests.codes.created:
11231123
self._logger.info("done")
11241124
else:
11251125
raise ResponseError(response)
@@ -1152,7 +1152,7 @@ def domains_remove(self, args):
11521152
finally:
11531153
progress.cancel()
11541154
progress.join()
1155-
if response.status_code == requests.codes.no_content: # @UndefinedVariable
1155+
if response.status_code == requests.codes.no_content:
11561156
self._logger.info("done")
11571157
else:
11581158
raise ResponseError(response)
@@ -1172,7 +1172,7 @@ def domains_list(self, args):
11721172
app = self._session.app
11731173
response = self._dispatch(
11741174
'get', "/v1/apps/{app}/domains".format(app=app))
1175-
if response.status_code == requests.codes.ok: # @UndefinedVariable
1175+
if response.status_code == requests.codes.ok:
11761176
domains = response.json()['results']
11771177
self._logger.info("=== {} Domains".format(app))
11781178
if len(domains) == 0:
@@ -1211,7 +1211,7 @@ def limits_list(self, args):
12111211
if not app:
12121212
app = self._session.app
12131213
response = self._dispatch('get', "/v1/apps/{}/config".format(app))
1214-
if response.status_code == requests.codes.ok: # @UndefinedVariable
1214+
if response.status_code == requests.codes.ok:
12151215
self._print_limits(app, response.json())
12161216
else:
12171217
raise ResponseError(response)
@@ -1267,7 +1267,7 @@ def limits_set(self, args):
12671267
finally:
12681268
progress.cancel()
12691269
progress.join()
1270-
if response.status_code == requests.codes.created: # @UndefinedVariable
1270+
if response.status_code == requests.codes.created:
12711271
version = response.headers['x-deis-release']
12721272
self._logger.info("done, v{}\n".format(version))
12731273

@@ -1313,7 +1313,7 @@ def limits_unset(self, args):
13131313
finally:
13141314
progress.cancel()
13151315
progress.join()
1316-
if response.status_code == requests.codes.created: # @UndefinedVariable
1316+
if response.status_code == requests.codes.created:
13171317
version = response.headers['x-deis-release']
13181318
self._logger.info("done, v{}\n".format(version))
13191319
self._print_limits(app, response.json())
@@ -1368,7 +1368,7 @@ def ps_list(self, args, app=None):
13681368
app = self._session.app
13691369
response = self._dispatch('get',
13701370
"/v1/apps/{}/containers".format(app))
1371-
if response.status_code != requests.codes.ok: # @UndefinedVariable
1371+
if response.status_code != requests.codes.ok:
13721372
raise ResponseError(response)
13731373
processes = response.json()
13741374
self._logger.info("=== {} Processes\n".format(app))
@@ -1417,7 +1417,7 @@ def ps_scale(self, args):
14171417
finally:
14181418
progress.cancel()
14191419
progress.join()
1420-
if response.status_code == requests.codes.no_content: # @UndefinedVariable
1420+
if response.status_code == requests.codes.no_content:
14211421
self._logger.info('done in {}s'.format(int(time.time() - before)))
14221422
self.ps_list({}, app)
14231423
else:
@@ -1451,7 +1451,7 @@ def tags_list(self, args):
14511451
if not app:
14521452
app = self._session.app
14531453
response = self._dispatch('get', "/v1/apps/{}/config".format(app))
1454-
if response.status_code == requests.codes.ok: # @UndefinedVariable
1454+
if response.status_code == requests.codes.ok:
14551455
self._print_tags(app, response.json())
14561456
else:
14571457
raise ResponseError(response)
@@ -1487,7 +1487,7 @@ def tags_set(self, args):
14871487
finally:
14881488
progress.cancel()
14891489
progress.join()
1490-
if response.status_code == requests.codes.created: # @UndefinedVariable
1490+
if response.status_code == requests.codes.created:
14911491
version = response.headers['x-deis-release']
14921492
self._logger.info("done, v{}\n".format(version))
14931493

@@ -1525,7 +1525,7 @@ def tags_unset(self, args):
15251525
finally:
15261526
progress.cancel()
15271527
progress.join()
1528-
if response.status_code == requests.codes.created: # @UndefinedVariable
1528+
if response.status_code == requests.codes.created:
15291529
version = response.headers['x-deis-release']
15301530
self._logger.info("done, v{}\n".format(version))
15311531
self._print_tags(app, response.json())
@@ -1585,7 +1585,7 @@ def keys_add(self, args):
15851585
sys.stdout.write("Uploading {} to Deis...".format(selected_key.id))
15861586
sys.stdout.flush()
15871587
response = self._dispatch('post', '/v1/keys', json.dumps(body))
1588-
if response.status_code == requests.codes.created: # @UndefinedVariable
1588+
if response.status_code == requests.codes.created:
15891589
self._logger.info('done')
15901590
else:
15911591
raise ResponseError(response)
@@ -1639,7 +1639,7 @@ def keys_list(self, args):
16391639
Usage: deis keys:list
16401640
"""
16411641
response = self._dispatch('get', '/v1/keys')
1642-
if response.status_code == requests.codes.ok: # @UndefinedVariable
1642+
if response.status_code == requests.codes.ok:
16431643
data = response.json()
16441644
if data['count'] == 0:
16451645
self._logger.info('No keys found')
@@ -1666,7 +1666,7 @@ def keys_remove(self, args):
16661666
sys.stdout.write("Removing {} SSH Key... ".format(key))
16671667
sys.stdout.flush()
16681668
response = self._dispatch('delete', "/v1/keys/{}".format(key))
1669-
if response.status_code == requests.codes.no_content: # @UndefinedVariable
1669+
if response.status_code == requests.codes.no_content:
16701670
self._logger.info('done')
16711671
else:
16721672
raise ResponseError(response)
@@ -1822,7 +1822,7 @@ def releases_info(self, args):
18221822
app = self._session.app
18231823
response = self._dispatch(
18241824
'get', "/v1/apps/{app}/releases/{version}".format(**locals()))
1825-
if response.status_code == requests.codes.ok: # @UndefinedVariable
1825+
if response.status_code == requests.codes.ok:
18261826
self._logger.info(json.dumps(response.json(), indent=2))
18271827
else:
18281828
raise ResponseError(response)
@@ -1841,7 +1841,7 @@ def releases_list(self, args):
18411841
if not app:
18421842
app = self._session.app
18431843
response = self._dispatch('get', "/v1/apps/{app}/releases".format(**locals()))
1844-
if response.status_code == requests.codes.ok: # @UndefinedVariable
1844+
if response.status_code == requests.codes.ok:
18451845
self._logger.info("=== {} Releases".format(app))
18461846
data = response.json()
18471847
for item in data['results']:
@@ -1887,7 +1887,7 @@ def releases_rollback(self, args):
18871887
finally:
18881888
progress.cancel()
18891889
progress.join()
1890-
if response.status_code == requests.codes.created: # @UndefinedVariable
1890+
if response.status_code == requests.codes.created:
18911891
new_version = response.json()['version']
18921892
self._logger.info("done, v{}".format(new_version))
18931893
else:

0 commit comments

Comments
 (0)