Merge pull request #3980 from bacongobbler/publisher-healthcheck-error

Matthew Fisher · Matthew Fisher · commit 4ca4f738b043 · 2015-07-09T14:31:31.000-07:00
fix(publisher): display http error if connection failed
diff --git a/publisher/server/publisher.go b/publisher/server/publisher.go
@@ -186,7 +186,7 @@ func (s *Server) IsPortOpen(hostAndPort string) bool {
 func (s *Server) HealthCheckOK(url string, expectedStatusCode int) bool {
 	resp, err := http.Get(url)
 	if err != nil {
-		log.Printf("healthcheck failed for %s (expected %d, got %v)\n", url, expectedStatusCode, err)
+		log.Printf("healthcheck failed for %s (%v)\n", url, err)
 		return false
 	}
 	if resp.StatusCode == expectedStatusCode {

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ func (s *Server) IsPortOpen(hostAndPort string) bool {`
`186`	`186`	`func (s *Server) HealthCheckOK(url string, expectedStatusCode int) bool {`
`187`	`187`	`resp, err := http.Get(url)`
`188`	`188`	`if err != nil {`
`189`		`- log.Printf("healthcheck failed for %s (expected %d, got %v)\n", url, expectedStatusCode, err)`
	`189`	`+ log.Printf("healthcheck failed for %s (%v)\n", url, err)`
`190`	`190`	`return false`
`191`	`191`	`}`
`192`	`192`	`if resp.StatusCode == expectedStatusCode {`