Skip to content

Commit 49a6b8f

Browse files
authored
fix(config): unset typed values (#41)
1 parent deb68f5 commit 49a6b8f

2 files changed

Lines changed: 16 additions & 4 deletions

File tree

cmd/config.go

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,24 @@ func (d *DryccCmd) ConfigUnset(appID string, procType string, configVars []strin
118118

119119
configObj.Values = valuesMap
120120

121-
_, err = config.Set(s.Client, appID, configObj)
121+
configObj, err = config.Set(s.Client, appID, func() api.Config {
122+
if procType != "" {
123+
return api.Config{TypedValues: map[string]api.ConfigValues{procType: valuesMap}}
124+
}
125+
return api.Config{Values: valuesMap}
126+
}())
127+
122128
quit <- true
123129
<-quit
124130
if d.checkAPICompatibility(s.Client, err) != nil {
125131
return err
126132
}
127133

128-
d.Print("done\n\n")
134+
if release, ok := configObj.Values["WORKFLOW_RELEASE"]; ok {
135+
d.Printf("done, %s\n\n", release)
136+
} else {
137+
d.Print("done\n\n")
138+
}
129139

130140
return d.ConfigList(appID, procType)
131141
}

cmd/config_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,10 @@ func TestConfigUnsetTypedValues(t *testing.T) {
263263
testutil.SetHeaders(w)
264264
if r.Method == "POST" {
265265
testutil.AssertBody(t, api.Config{
266-
Values: map[string]interface{}{
267-
"FOO": nil,
266+
TypedValues: map[string]api.ConfigValues{
267+
"web": {
268+
"FOO": nil,
269+
},
268270
},
269271
}, r)
270272
}

0 commit comments

Comments
 (0)