Skip to content

Commit 4336ef2

Browse files
committed
Merge pull request #4087 from mboersma/fix-mesos-image-builds
fix(mesos): build images with prefix and tag
2 parents c1b4b30 + 9546585 commit 4336ef2

7 files changed

Lines changed: 12 additions & 11 deletions

File tree

mesos/Makefile

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@ include ../includes.mk
22

33
REPO = deis
44
MESOS = 0.22.1-1.0.ubuntu1404
5-
MESOS_VERSION = v1.9.0
65
ZOOKEEPER_VERSION = 3.5.0
7-
86
MARATHON_VERSION = 0.8.2-RC3
97

108
repo_path = github.com/deis/deis/mesos
@@ -86,29 +84,29 @@ mesos-go: setup-gotools
8684

8785
mesos-template:
8886
sed "s/#VERSION#/$(MESOS)/g" template > Dockerfile
89-
docker build -t $(IMAGE_PREFIX)$@:$(MESOS_VERSION) .
87+
docker build -t $(IMAGE_PREFIX)$@:$(BUILD_TAG) .
9088
rm -f Dockerfile
9189

9290
mesos-master: mesos-go mesos-template
93-
sed "s/#VERSION#/$(MESOS_VERSION)/g" master > Dockerfile
91+
sed "s@#PREFIX#@$(IMAGE_PREFIX)@;s/#VERSION#/$(BUILD_TAG)/g" master > Dockerfile
9492
docker build -t $(IMAGE_PREFIX)$@:$(BUILD_TAG) .
9593
rm -f Dockerfile
9694

9795
mesos-slave: mesos-go mesos-template
98-
sed "s/#VERSION#/$(MESOS_VERSION)/g" slave > Dockerfile
96+
sed "s@#PREFIX#@$(IMAGE_PREFIX)@;s/#VERSION#/$(BUILD_TAG)/g" slave > Dockerfile
9997
docker build -t $(IMAGE_PREFIX)$@:$(BUILD_TAG) .
10098
rm -f Dockerfile
10199

102100
build-mesos-marathon: mesos-template
103-
sed "s/#MARATHON_VERSION#/$(MARATHON_VERSION)/;s/#VERSION#/$(MESOS_VERSION)/" build-marathon > Dockerfile
101+
sed "s/#MARATHON_VERSION#/$(MARATHON_VERSION)/;s@#PREFIX#@$(IMAGE_PREFIX)@;s/#VERSION#/$(BUILD_TAG)/g" build-marathon > Dockerfile
104102
docker build -t $(IMAGE_PREFIX)$@:$(BUILD_TAG) .
105103
rm -f Dockerfile
106104

107105
mesos-marathon: mesos-go build-mesos-marathon
108106
cp marathon Dockerfile
109107
docker cp `docker create $(IMAGE_PREFIX)build-mesos-marathon:$(BUILD_TAG) /bin/bash`:/marathon/target/marathon-assembly-$(MARATHON_VERSION).jar .
110108
mv marathon-assembly-$(MARATHON_VERSION).jar marathon-assembly.jar
111-
sed "s/#MARATHON_VERSION#/$(MARATHON_VERSION)/;s/#VERSION#/$(MESOS_VERSION)/" marathon > Dockerfile
109+
sed "s/#MARATHON_VERSION#/$(MARATHON_VERSION)/;s@#PREFIX#@$(IMAGE_PREFIX)@;s/#VERSION#/$(BUILD_TAG)/" marathon > Dockerfile
112110
docker build -t $(IMAGE_PREFIX)$@:$(BUILD_TAG) .
113111
rm -f Dockerfile
114112

mesos/build-marathon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM deis/mesos-template:#VERSION#
1+
FROM #PREFIX#mesos-template:#VERSION#
22

33
ENV DEBIAN_FRONTEND noninteractive
44
ENV MARATHON_VERSION=#MARATHON_VERSION#

mesos/marathon

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM deis/mesos-template:#VERSION#
1+
FROM #PREFIX#mesos-template:#VERSION#
22

33
EXPOSE 8080
44

mesos/master

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM deis/mesos-template:#VERSION#
1+
FROM #PREFIX#mesos-template:#VERSION#
22

33
COPY bin/master-boot /app/bin/boot
44

mesos/slave

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM deis/mesos-template:#VERSION#
1+
FROM #PREFIX#mesos-template:#VERSION#
22

33
COPY bin/slave-boot /app/bin/boot
44

mesos/template

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,5 @@ ENV DEBIAN_FRONTEND noninteractive
55
COPY build-mesos.sh /tmp/build.sh
66

77
RUN DOCKER_BUILD=true MESOS="#VERSION#" /tmp/build.sh
8+
9+
ENV DEIS_RELEASE 1.9.0-dev

mesos/zookeeper/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,4 @@ VOLUME ["/opt/zookeeper-data"]
1515

1616
ENTRYPOINT ["/app/bin/boot"]
1717

18+
ENV DEIS_RELEASE 1.9.0-dev

0 commit comments

Comments
 (0)