validate that App.id only contains [a-z0-9-] and is a valid domain name, with tests

Author: Gabriel Monroy

api/serializers.py

@@ -5,6 +5,8 @@
 
 from __future__ import unicode_literals
 
+import re
+
 from django.contrib.auth.models import User
 from rest_framework import serializers
 
@@ -165,6 +167,16 @@ class Meta:
         model = models.App
         read_only_fields = ('created', 'updated')
 
+    def validate_id(self, attrs, source):
+        """
+        Check that the ID is all lowercase
+        """
+        value = attrs[source]
+        match = re.match(r'^[a-z0-9-]+$', value)
+        if not match:
+            raise serializers.ValidationError("App IDs can only contain [a-z0-9-]")
+        return attrs
+
 
 class ContainerSerializer(serializers.ModelSerializer):
     """Serialize a :class:`~api.models.Container` model."""

api/tests/app.py

@@ -185,6 +185,9 @@ def test_app_actions(self):
     def test_app_errors(self):
         formation_id, app_id = 'autotest', 'autotest-errors'
         url = '/api/apps'
+        body = {'formation': formation_id, 'id': 'camelCase'}
+        response = self.client.post(url, json.dumps(body), content_type='application/json')
+        self.assertContains(response, 'App IDs can only contain [a-z0-9-]', status_code=400)
         body = {'formation': formation_id, 'id': app_id}
         response = self.client.post(url, json.dumps(body), content_type='application/json')
         self.assertEqual(response.status_code, 201)