Skip to content

Commit 39d2a2c

Browse files
author
Jonathan Chauncey
committed
fix(makefile): Update makefile and deploy.sh to work like the other repos
1 parent 4404e08 commit 39d2a2c

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

Makefile

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,15 @@
22
DEIS_REGISTRY ?= $(DEV_REGISTRY)/
33
IMAGE_PREFIX ?= deis
44
COMPONENT ?= workflow
5-
VERSION ?= git-$(shell git rev-parse --short HEAD)
6-
IMAGE = $(DEIS_REGISTRY)$(IMAGE_PREFIX)/$(COMPONENT):$(VERSION)
5+
BUILD_TAG ?= git-$(shell git rev-parse --short HEAD)
6+
IMAGE = $(DEIS_REGISTRY)$(IMAGE_PREFIX)/$(COMPONENT):$(BUILD_TAG)
77
SHELL_SCRIPTS = $(wildcard rootfs/bin/*) $(shell find "rootfs" -name '*.sh') $(wildcard _scripts/*.sh)
88

9+
info:
10+
@echo "Build tag: ${BUILD_TAG}"
11+
@echo "Registry: ${DEIS_REGISTRY}"
12+
@echo "Image: ${IMAGE}"
13+
914
check-docker:
1015
@if [ -z $$(which docker) ]; then \
1116
echo "Missing \`docker\` client which is required for development"; \
@@ -15,10 +20,10 @@ check-docker:
1520
prep-bintray-json:
1621
# TRAVIS_TAG is set to the tag name if the build is a tag
1722
ifdef TRAVIS_TAG
18-
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json | \
23+
@jq '.version.name |= "$(BUILD_TAG)"' _scripts/ci/bintray-template.json | \
1924
jq '.package.repo |= "deis"' > _scripts/ci/bintray-ci.json
2025
else
21-
@jq '.version.name |= "$(VERSION)"' _scripts/ci/bintray-template.json \
26+
@jq '.version.name |= "$(BUILD_TAG)"' _scripts/ci/bintray-template.json \
2227
> _scripts/ci/bintray-ci.json
2328
endif
2429

_scripts/deploy.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
cd "$(dirname "$0")" || exit 1
77

8-
export IMAGE_PREFIX=deisci VERSION=v2-alpha
8+
export IMAGE_PREFIX=deisci BUILD_TAG=v2-alpha
99
docker login -e="$DOCKER_EMAIL" -u="$DOCKER_USERNAME" -p="$DOCKER_PASSWORD"
1010
DEIS_REGISTRY='' make -C .. docker-build docker-push
1111
docker login -e="$QUAY_EMAIL" -u="$QUAY_USERNAME" -p="$QUAY_PASSWORD" quay.io

0 commit comments

Comments
 (0)